Test fundamental properties of CoinSelection.performSelection.
#2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generators and shrinkers in this module are for types defined in the `Balance` module.
jonathanknowles
force-pushed
the
jonathanknowles/adp-1037/test-coin-selection
branch
from
0bb5bd7 to
642b24c
Compare
These are similar to `liftShrink2`, but applicable to {8,9}-tuples.
The `assessTokenBundleSize` field now has same type as the equivalent field within `Balance.SelectionConstraints`. This should make it easier to reuse the `MockAssessTokenBundleSize` type and generators from `BalanceSpec` when we need to generate `MockSelectionConstraints` for the `CoinSelection` module.
jonathanknowles
force-pushed
the
jonathanknowles/adp-1037/test-coin-selection
branch
from
87082b4 to
4f5e341
Compare
jonathanknowles
commented
Oct 7, 2021
jonathanknowles
commented
Oct 7, 2021
In response to review comments: #2953 (comment) #2953 (comment)
sevanspowell
approved these changes
Oct 7, 2021
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number
ADP-1037
Summary
This PR tests fundamental properties of the
CoinSelection.performSelectionfunction.Details
In the case where
performSelectionsuccessfully produces aSelectionsfor a given set ofSelectionConstraintscsandSelectionParamsps, we verify that the following properties hold:selectionHasSufficientCollateral cs ps sselectionHasValidSurplus cs ps sNot included in this PR
This PR doesn't include:
performSelectionThese tests will be included in future PRs.