E2E tests: Construct -> Sign -> Submit #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
reviewed
Oct 5, 2021
| available = SHELLEY.wallets.get(@target_id)['balance']['available']['quantity'] | ||
| total = SHELLEY.wallets.get(@target_id)['balance']['total']['quantity'] | ||
| (available == amt + available_before) && (total == amt + total_before) | ||
| end |
KtorZ
reviewed
Oct 5, 2021
| tx_constructed = SHELLEY.transactions.construct(@wid, | ||
| payments = nil, | ||
| withdrawal = nil, | ||
| metadata) |
KtorZ
approved these changes
Oct 5, 2021
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
23c7cc1
Update fixture wallets
62b12ef
regenerate gemfile
ae88457
E2E tests: Construct -> Sign -> Submit
Comments
I've added some e2e tests for construct -> sign -> submit. (for extended testing of sign ep) These tests are to be executed against testnet:
There are still some tests to be unpended in integration tests after
KtorZ/ADP-919/sign-transactionis merged. Can be done here or in subsequent pr.Issue Number
ADP-919