Lenient SealedTx decoding #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
|
I guess the PR fails because of the commits it is based on? Will try to rebase on master |
KtorZ
force-pushed
the
abailly-iohk/lenient-sealedtx-decoding
branch
from
1328e62 to
2a068d8
Compare
|
bors r+ |
|
👎 Rejected by too few approved reviews |
KtorZ
approved these changes
Oct 4, 2021
| forAll selectFromPreparedBinaries $ \ bs -> | ||
| let result = parseJSONSealedTx $ Aeson.encode $ ApiBytesT @'Base64 bs | ||
| in result == Right bs & | ||
| counterexample ("Parse result: " <> show result) |
| parseJSON = fmap ApiT . parseSealedTxBytes @'Base64 | ||
| parseJSON v = do | ||
| tx <- parseSealedTxBytes @'Base16 v <|> parseSealedTxBytes @'Base64 v | ||
| pure $ ApiT tx |
ghost
marked this pull request as draft
|
I did not run all unit tests before pushing and some of them are failing. Will revert to draft status, apologies for the inconvenience. |
paweljakubas
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
lgtm. The properties will be even better when selectFromPreparedBinaries is replaced with genTx from cardano-api:gen soon (@sevanspowell is working on this)
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 5, 2021
2946: Lenient SealedTx decoding r=paweljakubas a=abailly-iohk > This is my very first PR in cardano-wallet so my apologies if I broke some rules of the land :) This simple PR allows clients to provide either a base16 or base64 encoding when submitting a transaction for signing and other endpoints relevant for the new signing process. It is based off of @KtorZ's #2943 PR as this strand of work was triggered by us tripping ourselves in the foot trying to sign a base16 encoded transaction. Co-authored-by: Arnaud Bailly <[email protected]> Co-authored-by: Pawel Jakubas <[email protected]>
|
Build failed: |
|
Need to fix a unit test, will push soon... |
paweljakubas
force-pushed
the
abailly-iohk/lenient-sealedtx-decoding
branch
from
cbc6ae0 to
f1b28ae
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 5, 2021
2946: Lenient SealedTx decoding r=paweljakubas a=abailly-iohk > This is my very first PR in cardano-wallet so my apologies if I broke some rules of the land :) This simple PR allows clients to provide either a base16 or base64 encoding when submitting a transaction for signing and other endpoints relevant for the new signing process. It is based off of @KtorZ's #2943 PR as this strand of work was triggered by us tripping ourselves in the foot trying to sign a base16 encoded transaction. Co-authored-by: Arnaud Bailly <[email protected]> Co-authored-by: Pawel Jakubas <[email protected]>
|
bors r- |
|
Canceled. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 5, 2021
2946: Lenient SealedTx decoding r=paweljakubas a=abailly-iohk > This is my very first PR in cardano-wallet so my apologies if I broke some rules of the land :) This simple PR allows clients to provide either a base16 or base64 encoding when submitting a transaction for signing and other endpoints relevant for the new signing process. It is based off of @KtorZ's #2943 PR as this strand of work was triggered by us tripping ourselves in the foot trying to sign a base16 encoded transaction. Co-authored-by: Arnaud Bailly <[email protected]> Co-authored-by: Pawel Jakubas <[email protected]>
|
Sorry for the confusion, PR now complete with test fixed and documentation added in swagger.yaml. |
|
Build failed: |
paweljakubas
force-pushed
the
abailly-iohk/lenient-sealedtx-decoding
branch
from
018dadf to
6e3d825
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR allows clients to provide either a base16 or base64 encoding when submitting a transaction for signing and other endpoints relevant for the new signing process. It is based off of @KtorZ's #2943 PR as this strand of work was triggered by us tripping ourselves in the foot trying to sign a base16 encoded transaction.