Preparation for testing of integrated CoinSelection module.
#2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
force-pushed
the
jonathanknowles/adp-1037/test-coin-selection-preparation
branch
from
3514c2f to
087f859
Compare
jonathanknowles
force-pushed
the
jonathanknowles/adp-1037/test-coin-selection-preparation
branch
4 times, most recently
from
b25c4c2 to
9acf950
Compare
This is intended: - to make the control flow a little clearer. - to make individual functions easier to test.
This function is unused within `Balance`, and only used by the top-level `CoinSelection` module. So it makes sense to locate it within the same module.
The `estimateTxSize` function is provided with a `TxSkeleton`, which is
constructed from a `SelectionSkeleton` and a `TransactionCtx`.
Therefore, provided that a `TxSkeleton` is constructed with the correct
maps of minted and burned assets, the `estimateTxSize` function does not
mind whether these values originate from a `SelectionSkeleton` or from a
`TransactionCtx`.
However, there are strong advantages to storing minted and burned assets
within `TransactionCtx` instead of `SelectionSkeleton`:
* Minted and burned assets remain constant over the course of an ongoing
coin selection.
* Therefore, the size and cost of minted and burned assets is constant
over the course of an ongoing coin selection.
* The `{gen,shrink}SelectionSkeleton` functions will no longer need to
generate and shrink minted and burned assets.
* The mock `computeMinimumCostLinear` function will no longer need to
determine the sizes of minted and burned assets, leading to faster
execution times for `BalanceSpec`.
* The `selectAssets` function will be able to populate the `assetsToMint`
and `assetsToBurn` fields of the `SelectionParams` object, since it
already has access to a `TransactionCtx` value.
This is an easy win, as the `TransactionCtx` now provides the maps of assets to mint and burn.
jonathanknowles
force-pushed
the
jonathanknowles/adp-1037/test-coin-selection-preparation
branch
from
9acf950 to
54279bc
Compare
sevanspowell
approved these changes
Oct 5, 2021
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/adp-1037/test-coin-selection-preparation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1037
Summary
This PR performs some groundwork in preparation for testing the integrated
CoinSelectionmodule. It:CoinSelection.performSelectionto clarify the control flow and make testing easier.prepareOutputsWithto the top-levelCoinSelectionmodule.SelectionSkeletontoTransactionCtx.assetsTo{Mint,Burn}field withinselectAssets.