-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collateral to coin selection. #2940
Merged
iohk-bors
merged 9 commits into
master
from
jonathanknowles/adp-1037/add-collateral-to-coin-selection
Oct 1, 2021
Merged
Add collateral to coin selection. #2940
iohk-bors
merged 9 commits into
master
from
jonathanknowles/adp-1037/add-collateral-to-coin-selection
Oct 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this function to simplify `whenCollateralRequired`. This function will also be used in a later commit.
jonathanknowles
force-pushed
the
jonathanknowles/adp-1037/add-collateral-to-coin-selection
branch
2 times, most recently
from
October 1, 2021 05:40
5313653
to
94b85a7
Compare
jonathanknowles
force-pushed
the
jonathanknowles/adp-1037/add-collateral-to-coin-selection
branch
from
October 1, 2021 05:45
94b85a7
to
bb93618
Compare
Use this to simplify `CoinSelection.performSelection`.
jonathanknowles
force-pushed
the
jonathanknowles/adp-1037/add-collateral-to-coin-selection
branch
from
October 1, 2021 05:52
ae98230
to
53e95d9
Compare
sevanspowell
approved these changes
Oct 1, 2021
bors r+ |
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/adp-1037/add-collateral-to-coin-selection
branch
October 1, 2021 08:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1037
Summary
This PR integrates the collateral selection algorithm into the top-level
CoinSelection
module.