Expose collateral selection errors in the API #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have the following set of names: - `certificateDepositAmount`. - `certificateDepositsTaken`. - `certificateDepositsReturned`. Since these all share the same prefix, it's more obvious that they refer to the same thing.
This allows us to remove quite a bit of nesting.
This will allow the minimum selection amount to be reported as part of the API error response.
sevanspowell
reviewed
Oct 1, 2021
| instance IsServerError (Collateral.SelectionError) where | ||
| toServerError e = | ||
| apiError err403 InsufficientCollateral $ T.unwords | ||
| [ "I'm unable to create this transaction because the balance" |
sevanspowell
approved these changes
Oct 1, 2021
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1039
Summary
This PR exposes collateral selection errors in the API, and adds descriptions of these errors to the API specification.
It also makes a couple of small tweaks to the internal coin selection API, to make the naming more consistent.
Not included in this PR
API integration tests that verify collateral selection errors.
We can't write these yet, as the collateral selection algorithm is not fully integrated into coin selection. (Though it soon will be, as part of ADP-1037.)