Add collateral to coin selection: preparation work #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
force-pushed
the
jonathanknowles/adp-1037/add-collateral-to-coin-selection-preparation
branch
from
fe56267 to
dc7a08d
Compare
This constant defines a default search space limit for collateral selection. We reuse this constant from the test suite, so we can be reasonably confident that performing selections with this limit will not use inordinate amounts of time and space.
This commit arranges that we have:
- PerformSelectionOf inputId
- PerformSelection
- Selection{Error,Params,Result}Of inputId
- Selection{Error,Params,Result}
The variants with the `Of` suffix all have an `inputId` type parameter,
allowing the test suite to use whatever type of input identifier is most
convenient.
The variants without the `Of` suffix are all specialized to `TxIn`,
making it easier for external modules to use these types.
As a result of this commit, the top-level `CoinSelection` module will no
longer need to state `TxIn` in every type signature that uses a type
from the `Collateral` module.
We also use `intCastMaybe` where necessary.
This will help to avoid multiple integral type conversions within the `CoinSelection` module. It requires a safe cast within the `Wallet` layer.
jonathanknowles
force-pushed
the
jonathanknowles/adp-1037/add-collateral-to-coin-selection-preparation
branch
from
dc7a08d to
d88bfcc
Compare
sevanspowell
approved these changes
Sep 30, 2021
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/adp-1037/add-collateral-to-coin-selection-preparation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1037
Summary
This PR makes the following changes in preparation for adding collateral to coin selection:
searchSpaceLimitDefaultconstant, and uses this constant in the test suite.CoinSelection.Collateralto simplify type signatures inCoinSelection.intCastfunction to replacefromInteger, allowing the compiler to check that integer conversions are safe.maximumCollateralInputCounttoInt.