remove redundant job condition in travis (already at top-level) #290
Conversation
KtorZ
force-pushed
the
KtorZ/travis-remove-redundant-constraints
branch
from
c549e33 to
99ff05a
Compare
.travis.yml
Outdated
| @@ -148,7 +125,7 @@ jobs: | |||
| # | |||
| ################################################################################ | |||
| - stage: build dependencies 🔩 | |||
| if: type != pull_request AND branch = master | |||
| if: type != pull_request | |||
There was a problem hiding this comment.
Now these will trigger on feature branches too?
There was a problem hiding this comment.
No, because of -> https://github.com/input-output-hk/cardano-wallet/pull/290/files#diff-354f30a63fb0907d4ad57269548329e3L27
We already have a condition that applies to ALL jobs. So it was slightly redundant to have these condition, except maybe that... we might not want to do any deploy stage with bors!
There was a problem hiding this comment.
@Anviking Okay, I went for a slightly different approach and instead, allowed bors to run on PR builds (which are much faster in the end so better fits the problem here). This makes bors do only what's necessary to ensure PRs build correctly, and then, still leave to travis to perform deployment and other heavier tasks when stuff reaches master.
There was a problem hiding this comment.
Confused by #290 (comment)
Aside from that, if we have to reduce our number of jobs: 👍
KtorZ
force-pushed
the
KtorZ/travis-remove-redundant-constraints
branch
from
99ff05a to
f567c04
Compare
Issue Number
Overview
Comments