Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cardano-node to 1.30.0 #2898

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Bump cardano-node to 1.30.0 #2898

merged 1 commit into from
Sep 21, 2021

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Sep 15, 2021 •
edited
Loading

  • update stack.yaml, nix, cabal.project for 1.30.0 node release
  • Update readme to mention 1.30.0 tag

Comments

Done in steps using the following commands in the cardano-node repo:

git diff 1.29.0 1.30.0-rc3 -- cabal.project
git diff 1.30.0-rc3 1.30.0-rc4 -- cabal.project
git diff 1.30.0-rc4 1.30.0 -- cabal.project

Issue Number

ADP-1133

@Anviking Anviking self-assigned this Sep 15, 2021
@Anviking Anviking force-pushed the anviking/ADP-1133/node-1.30.0 branch 2 times, most recently from ce14de6 to 80bc08e Compare September 15, 2021 13:34
@Anviking
Copy link
Member Author

bors try

iohk-bors bot added a commit that referenced this pull request Sep 15, 2021
@iohk-bors
Try #2898:
c465b4c
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 15, 2021

try

Build succeeded:

@Anviking
Copy link
Member Author

bors try

iohk-bors bot added a commit that referenced this pull request Sep 17, 2021
@iohk-bors
Try #2898:
167dd04
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 17, 2021

try

Build failed:

@Anviking Anviking changed the title Bump cardano-node to 1.30.0-rc3 Bump cardano-node to 1.30.0-rc4 Sep 20, 2021
@Anviking Anviking force-pushed the anviking/ADP-1133/node-1.30.0 branch 3 times, most recently from 6d340a8 to e859580 Compare September 20, 2021 09:28
Anviking
Anviking commented Sep 20, 2021
View reviewed changes
lib/shelley/src/Cardano/Wallet/Shelley/Network.hs
shelleyQry
shelleyQry
shelleyQry
shelleyQry
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With concrete eras, the constraints are much easier to handle.

@Anviking
Copy link
Member Author

bors try

iohk-bors bot added a commit that referenced this pull request Sep 20, 2021
@iohk-bors
Try #2898:
45370fa
@Anviking Anviking force-pushed the anviking/ADP-1133/node-1.30.0 branch from 5e60457 to c2bcd50 Compare September 20, 2021 10:46
@Anviking
Copy link
Member Author

bors try

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 20, 2021

try

Already running a review

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 20, 2021

try

Build succeeded:

@Anviking Anviking requested a review from rvl September 20, 2021 11:51
@Anviking
Bump cardano-node to 1.30.0
1979cdd 
Done in steps using the following commands in the cardano-node repo:
```
git diff 1.29.0 1.30.0-rc3 -- cabal.project
git diff 1.30.0-rc3 1.30.0-rc4 -- cabal.project
git diff 1.30.0-rc4 1.30.0 -- cabal.project
```
@Anviking Anviking force-pushed the anviking/ADP-1133/node-1.30.0 branch from 9f42e18 to 1979cdd Compare September 21, 2021 08:08
@Anviking Anviking changed the title Bump cardano-node to 1.30.0-rc4 Bump cardano-node to 1.30.0 Sep 21, 2021
@Anviking Anviking marked this pull request as ready for review September 21, 2021 08:20
@Anviking Anviking requested a review from piotr-iohk September 21, 2021 14:04
piotr-iohk
piotr-iohk approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing == lgtm

@Anviking
Copy link
Member Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 21, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 22197e1 into master Sep 21, 2021
@iohk-bors iohk-bors bot deleted the anviking/ADP-1133/node-1.30.0 branch September 21, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-iohk piotr-iohk piotr-iohk approved these changes

@rvl rvl Awaiting requested review from rvl

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anviking @piotr-iohk