Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add --env NAME=VALUE option to hspec runners #2889

Merged
merged 6 commits into from
Sep 14, 2021

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Sep 10, 2021

Adds extra option handling to the integration test suite.
Environment variables can be set from the command line, which can be helpful.

@rvl rvl requested a review from Anviking September 10, 2021 15:03
@rvl rvl self-assigned this Sep 10, 2021
@rvl rvl force-pushed the rvl/2812/hspec-runner branch 2 times, most recently from 8320967 to b13896d Compare September 13, 2021 11:09
@rvl rvl force-pushed the rvl/2812/hspec-runner branch from b13896d to f13287f Compare September 13, 2021 13:30
Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 If you really want pure: true — sure.

A bit torn on hspecMain-style functions hiding custom magic without being explicit about it.

@rvl
Copy link
Contributor Author

rvl commented Sep 14, 2021

Perhaps I could put our magic hspecMain into a different module? It's nice to have the common setup code for all test suites in one place.

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 14, 2021
2889: tests: Add --env NAME=VALUE option to hspec runners r=rvl a=rvl

Adds extra option handling to the integration test suite.
Environment variables can be set from the command line, which can be helpful.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 14, 2021

Build failed:

[95 of 96] Compiling Cardano.Pool.DB.Log ( src/Cardano/Pool/DB/Log.hs, dist/build/Cardano/Pool/DB/Log.o, dist/build/Cardano/Pool/DB/Log.dyn_o )
[96 of 96] Compiling Cardano.Pool.DB.Sqlite ( src/Cardano/Pool/DB/Sqlite.hs, dist/build/Cardano/Pool/DB/Sqlite.o, dist/build/Cardano/Pool/DB/Sqlite.dyn_o )
installing
Installing library in /nix/store/v7dk2kxipi95c0ffwgqxkzvx52l9nh8a-cardano-wallet-core-lib-cardano-wallet-core-2021.9.9/lib/x86_64-linux-ghc-8.10.5/cardano-wallet-core-2021.9.9-DN12qGtT0HF57cfilLRPmd
post-installation fixup
patching script interpreter paths in /nix/store/v7dk2kxipi95c0ffwgqxkzvx52l9nh8a-cardano-wallet-core-lib-cardano-wallet-core-2021.9.9
checking for references to /build/ in /nix/store/v7dk2kxipi95c0ffwgqxkzvx52l9nh8a-cardano-wallet-core-lib-cardano-wallet-core-2021.9.9...
patchelf: wrong ELF type
running install tests
/nix/store/v7dk2kxipi95c0ffwgqxkzvx52l9nh8a-cardano-wallet-core-lib-cardano-wallet-core-2021.9.9/package.conf.d/cardano-wallet-core-2021.9.9-DN12qGtT0HF57cfilLRPmd.conf  is present

@rvl
Copy link
Contributor Author

rvl commented Sep 14, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 14, 2021
2889: tests: Add --env NAME=VALUE option to hspec runners r=rvl a=rvl

Adds extra option handling to the integration test suite.
Environment variables can be set from the command line, which can be helpful.


2895: Logging and test improvements r=rvl a=rvl

A few miscellaneous improvements to logging and tests, used for the signTx feature.

### Comments

The individual commit messages should explain things well enough.

### Issue Number

ADP-919


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 14, 2021

Build failed (retrying...):

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 14, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 00f6ded into master Sep 14, 2021
@iohk-bors iohk-bors bot deleted the rvl/2812/hspec-runner branch September 14, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants