-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Add --env NAME=VALUE option to hspec runners #2889
Conversation
8320967
to
b13896d
Compare
b13896d
to
f13287f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 If you really want pure: true
— sure.
A bit torn on hspecMain
-style functions hiding custom magic without being explicit about it.
Perhaps I could put our magic bors r+ |
2889: tests: Add --env NAME=VALUE option to hspec runners r=rvl a=rvl Adds extra option handling to the integration test suite. Environment variables can be set from the command line, which can be helpful. Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed:
|
bors r+ |
2889: tests: Add --env NAME=VALUE option to hspec runners r=rvl a=rvl Adds extra option handling to the integration test suite. Environment variables can be set from the command line, which can be helpful. 2895: Logging and test improvements r=rvl a=rvl A few miscellaneous improvements to logging and tests, used for the signTx feature. ### Comments The individual commit messages should explain things well enough. ### Issue Number ADP-919 Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed (retrying...): |
Build succeeded: |
Adds extra option handling to the integration test suite.
Environment variables can be set from the command line, which can be helpful.