Move counterexample combinators to Test.QuickCheck.Extra
#2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is generally useful, as it:
- makes it easy to add values to the output of counterexamples.
- automatically pretty prints values.
This function is generally useful, so moving it to a common place will make it easier to reuse.
jonathanknowles
requested review from
sevanspowell
and removed request for
sevanspowell
sevanspowell
approved these changes
Sep 8, 2021
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/move-combinators-to-quickcheck-extra
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1070
Comments
This PR moves the following combinators to
Test.QuickCheck.Extra:reportverifyThese are generally useful and used by a variety of test modules, so it makes sense to locate them in a shared module, rather than importing them from
SelectionSpec.