Change bech32 prefix for 1854h purpose (shared wallets)

[paweljakubas]

• Prefix in bech32 is now acct_shared_ when 1854H is used
• core unit tests and swagger updated
• added integration tests check of the fix

Comments

• CIP-1854

Issue Number

adp-1114

[piotr-iohk]

Ok, so now when we create acct pub key from "Shelley" wallet with purpose 1854H we get acct_shared_xvk prefix:

curl -X POST http://localhost:8090/v2/wallets/82e11bf3aea612e92158855f702180eda754cea3/keys/0H \
-d '{"passphrase":"Secure Passphrase","format":"extended","purpose":"1854H"}' \
-H "Content-Type: application/json"

acct_shared_xvk1afqnpkmp32s54cl0w6k65tuewujm0v74ll0hclq67cae42u569edztaj7g4a2w0jpxa9avzhwkp2450acwf34mn0khw2g8fpd477tdglcle2g

OK.

However, it is not quite in-line with cardano-addresses, because when we create acct pub key there on "Shelley" wallet with purpose 1854H we still get acct_xvk:

echo budget picture inside clown oxygen grab laugh together emotion doctor betray defy ski face retire include loan salmon sign poverty soccer risk install gift \
| cardano-address key from-recovery-phrase Shelley \ <--------------------
| cardano-address key child 1854H/1815H/0H \
| cardano-address key public --with-chain-code

acct_xvk1afqnpkmp32s54cl0w6k65tuewujm0v74ll0hclq67cae42u569edztaj7g4a2w0jpxa9avzhwkp2450acwf34mn0khw2g8fpd477tdgwxt5v3

We need to explicitly say "Shared" to get proper prefix:

echo budget picture inside clown oxygen grab laugh together emotion doctor betray defy ski face retire include loan salmon sign poverty soccer risk install gift \
| cardano-address key from-recovery-phrase Shared \ <--------------------
| cardano-address key child 1854H/1815H/0H \
| cardano-address key public --with-chain-code

acct_shared_xvk1afqnpkmp32s54cl0w6k65tuewujm0v74ll0hclq67cae42u569edztaj7g4a2w0jpxa9avzhwkp2450acwf34mn0khw2g8fpd477tdglcle2g

So, I guess we need a change on cardano-addresses side too? What do you think @paweljakubas?

[piotr-iohk]

LGTM.

(note the remark/question around cardano-address change)

[piotr-iohk]

👍

[piotr-iohk]

bors r+

[iohk-bors]

Build succeeded:

• buildkite/cardano-wallet
• ci/hydra-build:required