Don't leak wallets from createWalletViaCLI #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There has been strange CI failures where the wallet seems overloaded (balance is 0, and wallet is unsynced even after 90s). They seem CLI specific. There may be several reasons for the CLI specific failures. But one is: It seems createWalletViaCLI does not automatically clean up wallets using ResourceT. In the CLI.Shelley.Wallets module there are 15 calls to createWalletViaCLI, but only 5 corresponding deleteWalletViaCLI ones. The wallet server does not perform well with many wallets. So leaking wallets might contribute to slowness and failures. We should simply make createWalletViaCLI use ResourceT. Running ``` NO_POOLS=1 NO_CLEANUP=1 stack test cardano-wallet:integration --ta '-j 8 --match "CLI"' ls $CLUSTER_DIR/wallets/*.sqlite | wc -l ``` I get 22 remaining files with the fix, compared to 49 without it.
rvl
approved these changes
Aug 26, 2021
|
bors r+ |
This was referenced Aug 26, 2021
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createWalletViaCLIrun inResourceTfor automatic cleanupComments
There has been strange CI failures where the wallet seems overloaded
(balance is 0, and wallet is unsynced even after 90s). They seem CLI
specific.
There may be several reasons for the CLI specific failures. But one is:
It seems createWalletViaCLI does not automatically clean up wallets
using ResourceT. In the CLI.Shelley.Wallets module there are 15 calls to
createWalletViaCLI, but only 5 corresponding deleteWalletViaCLI ones.
The wallet server does not perform well with many wallets. So leaking
wallets might contribute to slowness and failures.
We should simply make createWalletViaCLI use ResourceT.
Running
I get 22 remaining files with the fix, compared to 49 without it.
Issue Number
ADP-1090