Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Alonzo-case in decodeSignedTx #2846

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Aug 25, 2021

  1. Add missing Alonzo-case in decodeSignedTx, breaking the /v2/proxy/transactions
    endpoint.

  2. Replace the wildcard _ with a case for Byron, such that we don't
    repeat the mistake for future eras.

    Although, perhaps the decodeSignedTx will be simplified before then anyway.

We used to have integration tests for external tx submission, but they
were removed in #2612 to drop the cardano-transactions dependency.

This fix is not yet tested. I believe, with the tx rework, all txs will
be submitted through the external endpoint anyway. So then we will have
good coverage. For now perhaps a quick check is enough?

  • Seeing if I can figure out the alonzo-purple testnet configs to test

Comments

Issue Number

ADP-1094

1. Add missing Alonzo-case in decodeSignedTx, breaking the /v2/proxy/transactions
   endpoint.
2. Replace the wildcard `_` with a case for Byron, such that we don't
   repeat the mistake for future eras.

   Although, the decodeSignedTx will be simplified before then anyway.

We used to have integration tests for external tx submission, but they
were removed in #2612 to drop the cardano-transactions dependency.

This fix is not yet tested. I believe, with the tx rework, all txs will
be submitted through the external endpoint anyway. So then we will have
good coverage. For now perhaps a quick check is enough?
@Anviking Anviking self-assigned this Aug 25, 2021
@Anviking Anviking closed this Aug 25, 2021
@rvl rvl reopened this Aug 26, 2021
@rvl rvl merged commit 6045d20 into master Aug 26, 2021
@rvl rvl deleted the anviking/ADP-1094/alonzo-external-tx branch August 26, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants