Add missing Alonzo-case in decodeSignedTx #2846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing Alonzo-case in decodeSignedTx, breaking the /v2/proxy/transactions
endpoint.
Replace the wildcard
_
with a case for Byron, such that we don'trepeat the mistake for future eras.
Although, perhaps the decodeSignedTx will be simplified before then anyway.
We used to have integration tests for external tx submission, but they
were removed in #2612 to drop the cardano-transactions dependency.
This fix is not yet tested. I believe, with the tx rework, all txs will
be submitted through the external endpoint anyway. So then we will have
good coverage. For now perhaps a quick check is enough?
Comments
Issue Number
ADP-1094