Lower coverage requirement for prop_selectRandom_one_withAdaOnly.
#2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a flaky coverage check requirement, as seen in overnight
testing (2 out of 100 runs):
```
Failures:
test/unit/Cardano/Wallet/Primitive/Types/UTxOIndexSpec.hs:144:9:
1) Cardano.Wallet.Primitive.Types.UTxOIndex, Indexed UTxO set properties, Index Selection, prop_selectRandom_one_withAdaOnly
Insufficient coverage (after 1600 tests):
85.18% selected an entry
Only 85.18% selected an entry, but expected 90.00%
To rerun use: --match "/Cardano.Wallet.Primitive.Types.UTxOIndex/Indexed UTxO set properties/Index Selection/prop_selectRandom_one_withAdaOnly/"
```
sevanspowell
approved these changes
Aug 25, 2021
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 25, 2021
2843: Add functions `{gen,shrink}Tx` to `Primitive.Tx.Gen` r=jonathanknowles a=jonathanknowles
### Issue Number
ADP-1084
### Comments
This PR adds a reusable generator and shrinker for transactions (of type `Tx`) to the `Primitive.Tx.Gen` module.
It uses these functions to simplify or eliminate `Arbitrary` instances in the following modules:
- `Cardano.Wallet.Primitive.ModelSpec`
- `Cardano.Wallet.Primitive.TypesSpec`
- `Cardano.WalletSpec`
2844: Lower coverage requirement for `prop_selectRandom_one_withAdaOnly`. r=jonathanknowles a=jonathanknowles
This PR lowers a coverage check requirement in `prop_selectRandom_one_withAdaOnly`.
It should fix the following failure, which was seen in overnight testing (2 out of 100 runs):
```hs
Failures:
test/unit/Cardano/Wallet/Primitive/Types/UTxOIndexSpec.hs:144:9:
1) Cardano.Wallet.Primitive.Types.UTxOIndex, Indexed UTxO set properties, Index Selection, prop_selectRandom_one_withAdaOnly
Insufficient coverage (after 1600 tests):
85.18% selected an entry
Only 85.18% selected an entry, but expected 90.00%
To rerun use: --match "/Cardano.Wallet.Primitive.Types.UTxOIndex/Indexed UTxO set properties/Index Selection/prop_selectRandom_one_withAdaOnly/"
```
Co-authored-by: Jonathan Knowles <[email protected]>
Co-authored-by: IOHK <[email protected]>
|
Build failed (retrying...): #duplicate |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 25, 2021
2844: Lower coverage requirement for `prop_selectRandom_one_withAdaOnly`. r=jonathanknowles a=jonathanknowles
This PR lowers a coverage check requirement in `prop_selectRandom_one_withAdaOnly`.
It should fix the following failure, which was seen in overnight testing (2 out of 100 runs):
```hs
Failures:
test/unit/Cardano/Wallet/Primitive/Types/UTxOIndexSpec.hs:144:9:
1) Cardano.Wallet.Primitive.Types.UTxOIndex, Indexed UTxO set properties, Index Selection, prop_selectRandom_one_withAdaOnly
Insufficient coverage (after 1600 tests):
85.18% selected an entry
Only 85.18% selected an entry, but expected 90.00%
To rerun use: --match "/Cardano.Wallet.Primitive.Types.UTxOIndex/Indexed UTxO set properties/Index Selection/prop_selectRandom_one_withAdaOnly/"
```
Co-authored-by: Jonathan Knowles <[email protected]>
|
Build failed: #expected - cancelled? |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lowers a coverage check requirement in
prop_selectRandom_one_withAdaOnly.It should fix the following failure, which was seen in overnight testing (2 out of 100 runs):