Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump node to 1.29.0-rc3 #2842

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Bump node to 1.29.0-rc3 #2842

merged 1 commit into from
Aug 25, 2021

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Aug 24, 2021 •
edited
Loading

  • Bump node to 1.29.0-rc3
  • Regenerate CLI goldens
  • Update readme

Comments

Following

git diff 1.29.0-rc2 1.29.0-rc3 -- cabal.project

plus the cardano-node revision change itself.

Issue Number

ADP-1091

@Anviking Anviking requested a review from rvl August 24, 2021 17:21
@Anviking Anviking force-pushed the anviking/ADP-1091/rc3 branch 2 times, most recently from 143d156 to 436e259 Compare August 24, 2021 17:25
@Anviking Anviking self-assigned this Aug 24, 2021
@Anviking Anviking force-pushed the anviking/ADP-1091/rc3 branch from 436e259 to e2221eb Compare August 24, 2021 18:46
@Anviking
Copy link
Member Author

bors try

iohk-bors bot added a commit that referenced this pull request Aug 24, 2021
@iohk-bors
Try #2842:
99c2a3f
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 25, 2021

try

Build succeeded:

rvl
rvl approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 👍

@rvl
Copy link
Contributor

rvl commented Aug 25, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 25, 2021 •
edited by Anviking
Loading

Build failed:

unpacking sources
unpacking source archive /nix/store/hirjcfqqadsjrj2175fcrjcnava3blfd-cardano-wallet-core-test-unit-x86_64-w64-mingw32-2021.8.11-x86_64-w64-mingw32
source root is cardano-wallet-core-test-unit-x86_64-w64-mingw32-2021.8.11-x86_64-w64-mingw32
building
Git revision is cea3183df138d64af3e94dbeebb4937a7d11bb0a
Could not load wine-gecko. HTML rendering will be disabled.
Native IE detected, not doing registration
wine: configuration in '/build' has been updated.
002d:err:seh:setup_exception stack overflow 1552 bytes in thread 002d eip 000000007bc999b6 esp 0000000007da1000 stack 0x7da0000-0x7da1000-0x7fa0000
building of '/nix/store/vy71nkm0nxfmzk5brg72yni4mn7x52q5-cardano-wallet-core-test-unit-x86_64-w64-mingw32-2021.8.11-check-x86_64-w64-mingw32' timed out after 7200 seconds of silence

#2703

@rvl rvl merged commit cea3183 into master Aug 25, 2021
@rvl rvl deleted the anviking/ADP-1091/rc3 branch August 25, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anviking @rvl