-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust the totalUTxO
function to not exclude collateral inputs.
#2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
force-pushed
the
jonathanknowles/fix-total-utxo
branch
from
August 23, 2021 09:48
b358670
to
184482c
Compare
jonathanknowles
force-pushed
the
jonathanknowles/test-change-utxo
branch
from
August 23, 2021 12:15
06f0c93
to
da7c4df
Compare
jonathanknowles
force-pushed
the
jonathanknowles/fix-total-utxo
branch
2 times, most recently
from
August 24, 2021 02:13
b221bfd
to
ac68745
Compare
Anviking
force-pushed
the
jonathanknowles/test-change-utxo
branch
from
August 24, 2021 09:02
761ecc2
to
ea1717c
Compare
jonathanknowles
force-pushed
the
jonathanknowles/fix-total-utxo
branch
from
August 25, 2021 05:13
ac68745
to
0611304
Compare
Since `mockHash` works on any value whose type has a `Show` instance, we don't need to convert the transaction to a tuple before hashing it.
jonathanknowles
force-pushed
the
jonathanknowles/fix-total-utxo
branch
2 times, most recently
from
August 26, 2021 04:46
6fede69
to
2d74e7e
Compare
jonathanknowles
force-pushed
the
jonathanknowles/fix-total-utxo
branch
from
August 26, 2021 04:48
2d74e7e
to
2af944a
Compare
jonathanknowles
force-pushed
the
jonathanknowles/fix-total-utxo
branch
from
August 26, 2021 04:52
2af944a
to
0671e7e
Compare
sevanspowell
approved these changes
Aug 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1084
Comments
This PR adjusts the
totalUTxO
function so that collateral inputs are not excluded.