Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the totalUTxO function to not exclude collateral inputs. #2838

Merged
merged 4 commits into from
Aug 26, 2021

Conversation

jonathanknowles
Copy link
Contributor

@jonathanknowles jonathanknowles commented Aug 23, 2021

Issue Number

ADP-1084

Comments

This PR adjusts the totalUTxO function so that collateral inputs are not excluded.

@jonathanknowles jonathanknowles force-pushed the jonathanknowles/fix-total-utxo branch from b358670 to 184482c Compare August 23, 2021 09:48
@jonathanknowles jonathanknowles self-assigned this Aug 23, 2021
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/test-change-utxo branch from 06f0c93 to da7c4df Compare August 23, 2021 12:15
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/fix-total-utxo branch 2 times, most recently from b221bfd to ac68745 Compare August 24, 2021 02:13
@Anviking Anviking force-pushed the jonathanknowles/test-change-utxo branch from 761ecc2 to ea1717c Compare August 24, 2021 09:02
Base automatically changed from jonathanknowles/test-change-utxo to master August 24, 2021 10:11
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/fix-total-utxo branch from ac68745 to 0611304 Compare August 25, 2021 05:13
Since `mockHash` works on any value whose type has a `Show` instance,
we don't need to convert the transaction to a tuple before hashing it.
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/fix-total-utxo branch 2 times, most recently from 6fede69 to 2d74e7e Compare August 26, 2021 04:46
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/fix-total-utxo branch from 2d74e7e to 2af944a Compare August 26, 2021 04:48
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/fix-total-utxo branch from 2af944a to 0671e7e Compare August 26, 2021 04:52
@jonathanknowles jonathanknowles marked this pull request as ready for review August 26, 2021 05:37
Copy link
Contributor

@sevanspowell sevanspowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jonathanknowles
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 26, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit b2fa128 into master Aug 26, 2021
@iohk-bors iohk-bors bot deleted the jonathanknowles/fix-total-utxo branch August 26, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants