Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to cardano-node 1.29.0-rc1 #2831

Merged
merged 4 commits into from
Aug 21, 2021
Merged

Bump to cardano-node 1.29.0-rc1 #2831

merged 4 commits into from
Aug 21, 2021

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Aug 18, 2021 •
edited
Loading

  • Bump to cardano-node 1.29.0-rc1
  • Bump to the actual tag, when it exists
  • Move snapshot to cardano-haskell
  • Update readme
  • Fix arcane windows hydra issues - might not have been real errors

Issue Number

ADP-1081

Comments

@Anviking Anviking self-assigned this Aug 18, 2021
rvl
rvl reviewed Aug 19, 2021
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

stack.yaml Outdated
@@ -4,7 +4,7 @@
#
# NOTE: Remember to update the version matrix in README.md when
# bumping the Cardano version.
resolver: https://raw.githubusercontent.com/input-output-hk/cardano-haskell/c2aa1078ca8261d98cfce16d1131fbc687f6692b/snapshots/cardano-alonzo-purple-1.0.1.yaml
resolver: tmp-snapshot.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you would like to move the snapshot back into stack.yaml, feel free.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it helps the cache issues, but very happy to try. And even if not, it's easier to bump cabal.project and stack.yaml in the same repo than having the cardano-haskell indirection.

Copy link
Member Author

@Anviking Anviking Aug 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, the buildkite cache does still break 😕

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, pity - sounds like we need add a cache key then, based on the content of stack.yaml.

@Anviking Anviking force-pushed the anviking/ADP-1081/node-alonzo-rc branch from d62df56 to d3be764 Compare August 19, 2021 15:15
@Anviking Anviking changed the title Bump to cardano-node 9ee60ae1ed83102bedfd317848f53d975c2da153 Bump to cardano-node 1.29.0-rc1 Aug 19, 2021
@Anviking Anviking force-pushed the anviking/ADP-1081/node-alonzo-rc branch 2 times, most recently from 243f5a1 to f8c0d9d Compare August 19, 2021 18:41
@Anviking
Copy link
Member Author

bors try

iohk-bors bot added a commit that referenced this pull request Aug 20, 2021
@iohk-bors
Try #2831:
3d2039d
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 20, 2021

try

Build failed:

@Anviking Anviking marked this pull request as ready for review August 20, 2021 12:39
@Anviking
Copy link
Member Author

bors try

iohk-bors bot added a commit that referenced this pull request Aug 20, 2021
@iohk-bors
Try #2831:
c0b078a
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 20, 2021

try

Build failed:

rvl
rvl approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Please do squash the fixup commits before merging.

@rvl
Copy link
Contributor

rvl commented Aug 20, 2021

Those Hydra build failures seem to have been due to some builds getting killed by a sysadmin. Unfortunately the killed builds (and builds depending on them) were cached as failed, and so kept on failing until I restarted them all.

@Anviking
Copy link
Member Author

Anviking commented Aug 20, 2021 •
edited
Loading

I thought I tried restarting them before, but ran into exactly the same issues 🤔 — but I might have misread it

@Anviking Anviking force-pushed the anviking/ADP-1081/node-alonzo-rc branch from 4731833 to d7be0b9 Compare August 20, 2021 16:41
@Anviking
Copy link
Member Author

Thanks for the help @rvl !

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 20, 2021
@iohk-bors @Anviking @rvl
Merge #2831
67ccf20 
2831: Bump to cardano-node 1.29.0-rc1 r=Anviking a=Anviking

- [x] Bump to cardano-node 1.29.0-rc1
- [x] Bump to the actual tag, when it exists
- <s>Move snapshot to cardano-haskell</s>
- [x] Update readme
- [ ] Fix arcane windows hydra issues 

### Issue Number

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->

ADP-1081

### Comments

<!-- Additional comments or screenshots to attach if any -->


Co-authored-by: Johannes Lund <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 20, 2021 •
edited by Anviking
Loading

Build failed:

#2703

@Anviking
Copy link
Member Author

No, the recent failure is recent, and not cached.

Previously I saw:

---> killing remote-iserv...
installing
Installing library in /nix/store/v1dcwk9jk4y3bb7g6rrh9cnxv9b59a7z-cardano-wallet-core-lib-cardano-wallet-core-x86_64-w64-mingw32-2021.8.11/lib/x86_64-windows-ghc-8.10.5/cardano-wallet-core-2021.8.11-5hdA5nlgvpLBtT3ZFL9INo
post-installation fixup
patching script interpreter paths in /nix/store/v1dcwk9jk4y3bb7g6rrh9cnxv9b59a7z-cardano-wallet-core-lib-cardano-wallet-core-x86_64-w64-mingw32-2021.8.11

which I thought was related to https://input-output-rnd.slack.com/archives/CAP8NM7N0/p1629473846081300?thread_ts=1623935006.211500&cid=CAP8NM7N0

But this time it just failed with

Progress.o, dist/build/Cardano/Wallet/Primitive/SyncProgress.dyn_o )
[59 of 93] Compiling Cardano.Wallet.Network ( src/Cardano/Wallet/Network.hs, dist/build/Cardano/Wallet/Network.o, dist/build/Cardano/Wallet/Network.dyn_o )
[60 of 93] Compiling Cardano.Wallet.DB.Sqlite.Types ( src/Cardano/Wallet/DB/Sqlite/Types.hs, dist/build/Cardano/Wallet/DB/Sqlite/Types.o, dist/build/Cardano/Wallet/DB/Sqlite/Types.dyn_o )
[61 of 93] Compiling Cardano.Pool.DB.Sqlite.TH ( src/Cardano/Pool/DB/Sqlite/TH.hs, dist/build/Cardano/Pool/DB/Sqlite/TH.o, dist/build/Cardano/Pool/DB/Sqlite/TH.dyn_o )
/nix/store/qg8qhrxiab3r87xmaxbq565g1g8bnl57-stdenv-linux/setup: line 1311:   119 Killed                  $SETUP_HS build lib:cardano-wallet-core -j$(($NIX_BUILD_CORES > 4 ? 4 : $NIX_BUILD_CORES))
builder for '/nix/store/rkfgswz6rg31qy9kqgyykf5h0qf6hd8c-cardano-wallet-core-lib-cardano-wallet-core-2021.8.11.drv' failed with exit code 137

@Anviking
Copy link
Member Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 21, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 4bc6587 into master Aug 21, 2021
@iohk-bors iohk-bors bot deleted the anviking/ADP-1081/node-alonzo-rc branch August 21, 2021 19:18
@Anviking Anviking mentioned this pull request Aug 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anviking @rvl