docker-compose.yml: Use files provided in /config/$network for cardano-wallet container #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
approved these changes
Aug 18, 2021
piotr-iohk
force-pushed
the
piotr/ADP-1068/fix-docker-compose-2
branch
from
839bf8c to
01c4b8a
Compare
1 task
iohk-bors bot
added a commit
that referenced
this pull request
Sep 29, 2021
2933: remove unused node-config volume r=piotr-iohk a=piotr-iohk
<!--
Detail in a few bullet points the work accomplished in this PR.
Before you submit, don't forget to:
* Make sure the GitHub PR fields are correct:
✓ Set a good Title for your PR.
✓ Assign yourself to the PR.
✓ Assign one or more reviewer(s).
✓ Link to a Jira issue, and/or other GitHub issues or PRs.
✓ In the PR description delete any empty sections
and all text commented in <!--, so that this text does not appear
in merge commit messages.
* Don't waste reviewers' time:
✓ If it's a draft, select the Create Draft PR option.
✓ Self-review your changes to make sure nothing unexpected slipped through.
* Try to make your intent clear:
✓ Write a good Description that explains what this PR is meant to do.
✓ Jira will detect and link to this PR once created, but you can also
link this PR in the description of the corresponding Jira ticket.
✓ Highlight what Testing you have done.
✓ Acknowledge any changes required to the Documentation.
-->
- [ ] remove unused node-config volume
### Comments
There was unused node-config volume on the node docker, leftover from #2830, which seems to cause problems on starting docker-compose with newer version of the node (1.29.0 -> 1.30.1) on top of older db.
### Issue Number
ADP-1165
Co-authored-by: Piotr Stachyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cardano-node docker image doesn't provide a nice tree of config files for various deployments. But the cardano-wallet docker image now does.
So use these configs when starting cardano-wallet in
docker-compose.ymlIssue Number
ADP-1068 / #2806
Comments
Wait until just before the next release to merge this.