Temporarily disable broken hp2pretty in restore bench #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The heap profile is so large that hp2pretty fails
```
hp2pretty: internal error: Unable to commit 6069157888 bytes of memory
(GHC version 8.8.4 for x86_64_unknown_linux)
Please report this as a GHC bug: https://www.haskell.org/ghc/reportabug
./.buildkite/bench-restore.sh: line 42: 126586 Aborted (core dumped) hp2pretty $artifact_name.hp
```
Allowing the failure to exist hides the results of the actual
benchmarks:
- makes checking the results more time-consuming
- could lead to real errors going unnoticed.
Anviking
force-pushed
the
anviking/ADP-1074/hp2pretty-workaround
branch
from
ba79b59 to
ae8d8bd
Compare
rvl
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
None / Will require ADP-1074 for a proper fix.
Comments
Allowing the failure to exist hides the results of the actual
benchmarks:
Test build: https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1054#87ef8967-0fee-4fb5-9083-0d66598eb0d7