Add maxCollateralInputs to ProtocolParameters #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
approved these changes
Aug 10, 2021
| -- | ||
| -- If this conversion would under/overflow, there is not much we can do except | ||
| -- to hastily exit. | ||
| unsafeToWord16 :: Integral n => n -> Word16 |
There was a problem hiding this comment.
Perhaps you could combine this with unsafeToWord64 and make
Suggested change
| unsafeToWord16 :: Integral n => n -> Word16 | |
| unsafeToWord :: (Integral n, Integral w) => n -> w |
sevanspowell
force-pushed
the
sevanspowell/adp-958/maximum-collateral-inputs
branch
from
d40551e to
78411fd
Compare
rvl
force-pushed
the
sevanspowell/adp-958/maximum-collateral-inputs
branch
from
db01eda to
b70f385
Compare
rvl
approved these changes
Aug 11, 2021
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 11, 2021
2813: Add maxCollateralInputs to ProtocolParameters r=sevanspowell a=sevanspowell # Issue Number ADP-958 # Overview - Included the maxCollateralInputs protocol parameter in the ProtocolParameters data type. # Comments - No tests exist for this structure, I believe this structure is tested implicitly via the `ApiNetworkParameters` structure. But since modifying that structure would encroach on ADP-1061, I'm going to leave this without tests for now. If anyone can think of a test they'd like to see, don't hesitate to suggest one! Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 11, 2021
2813: Add maxCollateralInputs to ProtocolParameters r=sevanspowell a=sevanspowell # Issue Number ADP-958 # Overview - Included the maxCollateralInputs protocol parameter in the ProtocolParameters data type. # Comments - No tests exist for this structure, I believe this structure is tested implicitly via the `ApiNetworkParameters` structure. But since modifying that structure would encroach on ADP-1061, I'm going to leave this without tests for now. If anyone can think of a test they'd like to see, don't hesitate to suggest one! Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
|
bors retry |
|
Already running a review |
|
Build failed: However it looks like it completed? |
|
bors retry |
|
Oops, sorry I pushed a minor fix to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-958
Overview
Comments
ApiNetworkParametersstructure. But since modifying that structure would encroach on ADP-1061, I'm going to leave this without tests for now. If anyone can think of a test they'd like to see, don't hesitate to suggest one!