Refresh GitHub issue and PR templates #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
Hi @rvl, this seems like a great improvement!
I've added a few comments and suggestions.
| description: | | ||
| Operating system on which you are running | ||
| `cardano-wallet`. Please include the version. For Linux, | ||
| please specify your distribution. |
There was a problem hiding this comment.
Perhaps uname -a would provide helpful info here, for those using Linux. On my system, it prints:
Linux neon 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
There was a problem hiding this comment.
Yeah kernel version is not highly relevant to us, but it can give hints about the exact distro version, and the arch of course.
| - Own Docker image (please specify) | ||
| - Nix | ||
| - via Daedalus installer | ||
| - Other |
| about: | | ||
| Users: Please feel welcome to ask for help from the IOHK | ||
| Technical Support team. They are knowledgeable about commonly | ||
| experienced issues and workarounds. |
GitHub now supports full YAML for issue templates, so hopefully this will help us get better quality submissions.
rvl
force-pushed
the
rvl/github-issue-templates
branch
from
3db5761 to
52a3d69
Compare
rvl
force-pushed
the
rvl/github-issue-templates
branch
from
8d9d4c9 to
cfcb41e
Compare
|
Thanks for the review comments. I have applied them and tested the templates on a forked repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub now supports full YAML for issue templates, so hopefully this will help us get better quality submissions.
Issue Number
None