Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix/regenerate.sh: Fix .stack-to-nix.cache bug #2795

Merged
merged 5 commits into from
Aug 3, 2021

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Aug 2, 2021

Issue Number

Found during ADP-1053.

Overview

@rvl rvl requested review from jbgi, hamishmack and sevanspowell August 2, 2021 07:03
@rvl rvl self-assigned this Aug 2, 2021
Copy link
Contributor

@sevanspowell sevanspowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took it for a spin, looks good to me!

shell.nix Outdated
@@ -60,6 +62,11 @@ let

meta.platforms = lib.platforms.unix;
};

helpCommand = with pkgs.buildPackages; writeShellScriptBin "help" ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just for fun?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder command -- removed now.

@rvl rvl force-pushed the rvl/nix-shell-cabal-wrapper branch 3 times, most recently from a2e7eb1 to 7109cfc Compare August 2, 2021 17:21
@rvl rvl force-pushed the rvl/nix-shell-cabal-wrapper branch from 7109cfc to 7e0a069 Compare August 3, 2021 01:55
@rvl
Copy link
Contributor Author

rvl commented Aug 3, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 3, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit b446073 into master Aug 3, 2021
@iohk-bors iohk-bors bot deleted the rvl/nix-shell-cabal-wrapper branch August 3, 2021 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants