Fix PatternMatchFail error in shared wallet integration tests #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The postSharedWallet request was failing for some reason, but instead of saying that the request failed, it said: uncaught exception: PatternMatchFail src/Test/Integration/Scenario/API/Shared/Wallets.hs:1029:25-75: Non-exhaustive patterns in lambda This change lets it print the correct error message depending on whether the request failed or the shared wallet was pending.
paweljakubas
approved these changes
Aug 3, 2021
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 3, 2021
2793: Fix PatternMatchFail error in shared wallet integration tests r=rvl a=rvl ### Issue Number Found during ADP-1059. ### Overview This error was seen when trying to merge #2790 (comment). The `postSharedWallet` request was failing for some reason, but instead of saying that the request failed, it said: ``` uncaught exception: PatternMatchFail src/Test/Integration/Scenario/API/Shared/Wallets.hs:1029:25-75: Non-exhaustive patterns in lambda ``` This change lets it print the correct error message depending on whether the request failed or the shared wallet was pending. ### Comments I'm not sure why the `postSharedWallets` request failed in the first place. Any ideas @paweljakubas ? Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: IOHK <[email protected]>
|
Build failed: |
|
The STAKE_POOLS_JOIN_01 flakiness seems to be back, although it never really left. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Found during ADP-1059.
Overview
This error was seen when trying to merge #2790 (comment).
The
postSharedWalletrequest was failing for some reason, but instead of saying that the request failed, it said:This change lets it print the correct error message depending on whether the request failed or the shared wallet was pending.
Comments
I'm not sure why the
postSharedWalletsrequest failed in the first place. Any ideas @paweljakubas ?