Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify wording of CannotCoverFee API error. #2784

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Clarify wording of CannotCoverFee API error. #2784

merged 2 commits into from
Jul 30, 2021

Conversation

jonathanknowles
Copy link
Contributor

@jonathanknowles jonathanknowles commented Jul 30, 2021 •
edited
Loading

Issue

https://input-output-rnd.slack.com/archives/CDM8B0AN9/p1627563147092700

Overview

This PR tries to clarify the wording of the CannotCoverFee API error.

It also fixes the broken "I need about pretty n ada" wording. (The "pretty" was erroneously included in the generated text output.)

@jonathanknowles jonathanknowles self-assigned this Jul 30, 2021
rvl
rvl approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, thanks!

@rvl
Copy link
Contributor

rvl commented Jul 30, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 30, 2021
@iohk-bors @jonathanknowles
Merge #2784
469f112 
2784: Clarify wording of `CannotCoverFee` API error. r=rvl a=jonathanknowles

# Issue

https://input-output-rnd.slack.com/archives/CDM8B0AN9/p1627563147092700

# Overview

This PR tries to clarify the wording of the `CannotCoverFee` API error.

It also fixes the broken "I need about pretty n ada" wording. (The "pretty" was erroneously included in the generated text output.)

Co-authored-by: Jonathan Knowles <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 30, 2021 •
edited by Anviking
Loading

Build failed:

The log has lots of weeder errors, such as:

weeder
src/Cardano/Wallet.hs:969:1: error: deleteWallet is unused

    967 ┃     -> WalletId
    968 ┃     -> ExceptT ErrNoSuchWallet IO ()
    969 ┃ deleteWallet ctx wid = db & \DBLayer{..} -> do
    970 ┃     mapExceptT atomically $ removeWallet wid
    971 ┃   where

   Delete this definition or add ‘Cardano.Wallet.deleteWallet’ as a root to fix this error.

#2785

@jonathanknowles
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 30, 2021
@iohk-bors @jonathanknowles
Merge #2784
740265b 
2784: Clarify wording of `CannotCoverFee` API error. r=jonathanknowles a=jonathanknowles

# Issue

https://input-output-rnd.slack.com/archives/CDM8B0AN9/p1627563147092700

# Overview

This PR tries to clarify the wording of the `CannotCoverFee` API error.

It also fixes the broken "I need about pretty n ada" wording. (The "pretty" was erroneously included in the generated text output.)

Co-authored-by: Jonathan Knowles <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 30, 2021 •
edited by Anviking
Loading

Build failed:

Failures:

  src/Test/Integration/Scenario/CLI/Shelley/Transactions.hs:387:59:
  1) CLI Specifications, SHELLEY_CLI_TRANSACTIONS, TRANS_ESTIMATE_09 - Invalid amount, []
       uncaught exception: IOException of type ResourceVanished
       fd:138: hFlush: resource vanished (Broken pipe)

  To rerun use: --match "/CLI Specifications/SHELLEY_CLI_TRANSACTIONS/TRANS_ESTIMATE_09 - Invalid amount/[]/"

Randomized with seed 1488918225

Finished in 920.3968 seconds, used 1014.5101 seconds of CPU time
859 examples, 1 failure, 42 pending

#2855

@rvl
Copy link
Contributor

rvl commented Jul 30, 2021

Hmm

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 30, 2021
@iohk-bors @jonathanknowles
Merge #2784
5d9fa83 
2784: Clarify wording of `CannotCoverFee` API error. r=rvl a=jonathanknowles

# Issue

https://input-output-rnd.slack.com/archives/CDM8B0AN9/p1627563147092700

# Overview

This PR tries to clarify the wording of the `CannotCoverFee` API error.

It also fixes the broken "I need about pretty n ada" wording. (The "pretty" was erroneously included in the generated text output.)

Co-authored-by: Jonathan Knowles <[email protected]>
@rvl rvl merged commit 8cd4dfd into master Jul 30, 2021
@rvl rvl deleted the jonathanknowles/correct-error-message branch July 30, 2021 12:22
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 30, 2021

Build failed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-iohk piotr-iohk piotr-iohk approved these changes

@rvl rvl rvl approved these changes

Assignees

@jonathanknowles jonathanknowles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathanknowles @rvl @piotr-iohk