More integration tests for CLI (including minor fixes in CLI) #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
commented
May 17, 2019
| if (title == "40 chars hex") then | ||
| c `shouldBe` ExitSuccess | ||
| else | ||
| c `shouldBe` ExitFailure 1 |
There was a problem hiding this comment.
This is slightly inconsistent I think. I suppose the response code should be always 1 (currently for valid hex, but not existing wallet it is 0, for others it is 1)
added 3 commits
May 17, 2019 12:49
…ays meaningful in case of invalid --size
- moving test data to separate module TestData.hs - extracting methods for interacting with CLI to DSL - few more test cases
piotr-iohk
force-pushed
the
piotr/96/more_cli_cases
branch
from
9b8ebba to
9935f7c
Compare
KtorZ
approved these changes
May 17, 2019
| "15" -> mnemonicToText @15 . entropyToMnemonic <$> genEntropy | ||
| "18" -> mnemonicToText @18 . entropyToMnemonic <$> genEntropy | ||
| "21" -> mnemonicToText @21 . entropyToMnemonic <$> genEntropy | ||
| "24" -> mnemonicToText @24 . entropyToMnemonic <$> genEntropy |
| hPutStr i (passphrase ++ "\n") | ||
| hPutStr i (passphrase ++ "\n") | ||
| hFlush i | ||
| hClose i |
| { std_in = CreatePipe, std_out = CreatePipe, std_err = CreatePipe } | ||
| withCreateProcess process $ \stdIn _ _ h -> do | ||
| case stdIn of | ||
| Nothing -> return () |
There was a problem hiding this comment.
I wonder if this should "throw". Since we use CreatePipe this must be Just. If not, the test might hang forever.
| if (title == "40 chars hex") then | ||
| c `shouldBe` ExitSuccess | ||
| else | ||
| c `shouldBe` ExitFailure 1 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#96
Overview
cardano-wallet-launcherandcardano-walletfor both parameters (--helpand-h)mnemonic generateto always showInvalid mnemonic size. Expected one of: 9,12,15,18,21,24for invalid--size(it used to show rather unpleasentInt is an integer number between -9223372036854775808 and 9223372036854775807.when the provided--sizewas not Int)TestData.hsand extracting methods for interacting with CLI toDSL.hs)Comments