Byron construct tx endpoint - initial integration tests #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
force-pushed
the
piotr/testing-byron-construct-tx
branch
2 times, most recently
from
9f3991d to
83dc616
Compare
paweljakubas
approved these changes
Jul 20, 2021
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 20, 2021
2760: Byron construct tx endpoint - initial integration tests r=piotr-iohk a=piotr-iohk # Issue Number ADP-909 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Adding integration tests for Byron construct tx ep. **NOTE:** only `payments` request parameter is tested, as according to https://input-output-rnd.slack.com/archives/GBT05825V/p1626077556008700?thread_ts=1625814178.001100&cid=GBT05825V it should be the only one supported in byront construct tx ep. # Comments Byron construct tx endpoint returns: - For Byron wallets: `500 - Something went wrong` - For Icarus wallets: `403`: ``` "code":"invalid_wallet_type", "message":"It is regrettable but you've just attempted an operation that is invalid for this type of wallet. Only new 'Shelley' wallets can do something with rewards and this one isn't."} ``` Therefore tests have been mostly marked as `pendingWith`. Co-authored-by: Piotr Stachyra <[email protected]>
|
Build failed: |
piotr-iohk
force-pushed
the
piotr/testing-byron-construct-tx
branch
from
83dc616 to
4a669a7
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 20, 2021
2760: Byron construct tx endpoint - initial integration tests r=piotr-iohk a=piotr-iohk # Issue Number ADP-909 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Adding integration tests for Byron construct tx ep. **NOTE:** only `payments` request parameter is tested, as according to https://input-output-rnd.slack.com/archives/GBT05825V/p1626077556008700?thread_ts=1625814178.001100&cid=GBT05825V it should be the only one supported in byront construct tx ep. # Comments Byron construct tx endpoint returns: - For Byron wallets: `500 - Something went wrong` - For Icarus wallets: `403`: ``` "code":"invalid_wallet_type", "message":"It is regrettable but you've just attempted an operation that is invalid for this type of wallet. Only new 'Shelley' wallets can do something with rewards and this one isn't."} ``` Therefore tests have been mostly marked as `pendingWith`. Co-authored-by: Piotr Stachyra <[email protected]>
|
Build failed: #duplicate (cached failure) |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-909
Overview
NOTE: only
paymentsrequest parameter is tested, as according to https://input-output-rnd.slack.com/archives/GBT05825V/p1626077556008700?thread_ts=1625814178.001100&cid=GBT05825V it should be the only one supported in byront construct tx ep.Comments
Byron construct tx endpoint returns:
500 - Something went wrong403:Therefore tests have been mostly marked as
pendingWith.