Add coverage checks to property tests for TokenMap.intersection
#2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This combinator provides a way to generate larger arbitrary values through simple monoidal concatenation of smaller arbitrary values.
Before this change, coverage of the intersection is not empty" condition was only 1%.
| -- generate larger values of 'A', based on simple monoidal concatenation of | ||
| -- multiple smaller values. | ||
| -- | ||
| newtype ManyFolded a = ManyFolded |
There was a problem hiding this comment.
This is required because the available Arbitrary instance for TokenMap is something like this:
instance Arbitrary TokenMap where
arbitrary = genTokenMapSmallRange
right?
I think I prefer Hedgehog's use of functions to Quickcheck's typeclass instances, but that's not the question here.
There was a problem hiding this comment.
I found this confusing @jonathanknowles.
Adding in Blind didn't help (couldn't Show be defined with show . mconcat?
Why can't we just use the QuickCheck size parameter? See Coding Standards - QuickCheck.
rvl
reviewed
Jul 12, 2021
There was a problem hiding this comment.
Thanks @jonathanknowles .
Coverage checks - good.
ManyFolded - unsure.
| -- generate larger values of 'A', based on simple monoidal concatenation of | ||
| -- multiple smaller values. | ||
| -- | ||
| newtype ManyFolded a = ManyFolded |
There was a problem hiding this comment.
I found this confusing @jonathanknowles.
Adding in Blind didn't help (couldn't Show be defined with show . mconcat?
Why can't we just use the QuickCheck size parameter? See Coding Standards - QuickCheck.
This allows the generation and shrinking of token quantities from a range that depends on the size parameter.
This allows the generation and shrinking of token names from a range that depends on the size parameter.
jonathanknowles
added a commit
that referenced
this pull request
Jul 13, 2021
In this change, we use sized generators for token maps instead of relying on the `ManyFolded` combinator. In response to review feedback: #2756 (comment)
jonathanknowles
added a commit
that referenced
this pull request
Jul 13, 2021
In this change, we use sized generators for token maps instead of relying on the `ManyFolded` combinator. In response to review feedback: #2756 (comment)
jonathanknowles
force-pushed
the
jonathanknowles/token-map-intersection-test-coverage
branch
from
86f4856 to
4fae8c4
Compare
This allows the generation and shrinking of token policy identifiers from a range that depends on the size parameter.
This allows the generation and shrinking of asset identifiers from a range that depends on the size parameter.
This allows the generation and shrinking of token maps where the number of entries, the range of asset identifiers, and the range of token quantities all depend on the size parameter.
In this change, we use sized generators for token maps instead of relying on the `ManyFolded` combinator. In response to review feedback: #2756 (comment)
jonathanknowles
force-pushed
the
jonathanknowles/token-map-intersection-test-coverage
branch
from
4fae8c4 to
5673f74
Compare
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/token-map-intersection-test-coverage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-997
Pre-merge checks
(✅ 1000 test runs with
--match "/Token map properties/Arithmetic/prop_intersection"passed with no failures.)Overview
PR #2725 added a
TokenMap.intersectionfunction and property tests.This PR:
prop_intersection_*series of properties.