More integration tests for construct tx endpoint #2751

piotr-iohk · 2021-07-05T14:11:39Z

Issue Number

ADP-909

Overview

Integration tests covering:

Comments / Issues

Should construct ep return 200 instead of 202 (coin selection returns 200)
amount field would be probably handy to have in the response
Output field on response is empty ("output": []) on payment transactions, which seems like a bug (to be addressed in ADP-985)... for now tests marked as pendingWith
Deposit is empty on construct tx response on joining pool and shouldn't
You can quit pool before even joining
errMsg404NoSuchPool is not returned when trying to join absent pool

paweljakubas

lgtm

piotr-iohk · 2021-07-07T09:59:16Z

bors r+

2751: More integration tests for construct tx endpoint r=piotr-iohk a=piotr-iohk # Issue Number ADP-909 # Overview Integration tests covering: - [x] More malformed examples - [x] Only validate_interval - [x] Tx with only metadata - [x] Tx with only withdrawal from self and external - [x] Only single output tx ⚠️ `pending` - outputs are empty - [x] Only multi-output tx ⚠️ `pending` - outputs are empty - [x] Multi asset transactions ⚠️ `pending` - outputs are empty - [x] Join and quit pool - join ⚠️ `pending` - deposits are empty - quit ⚠️ `pending` - can quit when you didn't join - errMsg404NoSuchPool ⚠️ `pending` - error not returned when should be - [ ] ~Minting~ - [x] validate_interval on different transactions (payments, delegations, mint) - invalid_before / invalid_hereafter ⚠️ `pending` - can be < 0 but shouldn't - [x] Transaction with all (payments, delegations, mint, metadata, withdrawal, validate_interval) # Comments / Issues - Should construct ep return `200` instead of `202` (coin selection returns `200`) - `amount` field would be probably handy to have in the response - Output field on response is empty (`"output": []`) on payment transactions, which seems like a bug (to be addressed in ADP-985)... for now tests marked as `pendingWith` - Deposit is empty on construct tx response on joining pool and shouldn't - You can quit pool before even joining - errMsg404NoSuchPool is not returned when trying to join absent pool Co-authored-by: Piotr Stachyra <[email protected]>

iohk-bors · 2021-07-07T10:39:20Z

Build failed:

buildkite/cardano-wallet\



cardano-wallet                 > Failures:
--
  | cardano-wallet                 >
  | cardano-wallet                 >   src/Test/Integration/Scenario/CLI/Shelley/Wallets.hs:285:56:
  | cardano-wallet                 >   1) CLI Specifications, SHELLEY_CLI_WALLETS, WALLETS_CREATE_04 - Wallet names invalid, name is too short: expected at least 1 character
  | cardano-wallet                 >        uncaught exception: IOException of type ResourceVanished
  | cardano-wallet                 >        fd:146: hFlush: resource vanished (Broken pipe)
  | cardano-wallet                 >
  | cardano-wallet                 >   To rerun use: --match "/CLI Specifications/SHELLEY_CLI_WALLETS/WALLETS_CREATE_04 - Wallet names invalid/name is too short: expected at least 1 character/"
  | cardano-wallet                 >
  | cardano-wallet                 > Randomized with seed 1377329000
  | cardano-wallet                 >
  | cardano-wallet                 > Finished in 907.3185 seconds, used 996.7970 seconds of CPU time
  | cardano-wallet                 > 836 examples, 1 failure, 21 pending

#2753

- single/multi payments - assets payments - metadata - withdrawals - invalid payloads

piotr-iohk · 2021-07-07T12:38:36Z

bors r+

2751: More integration tests for construct tx endpoint r=piotr-iohk a=piotr-iohk # Issue Number ADP-909 # Overview Integration tests covering: - [x] More malformed examples - [x] Only validate_interval - [x] Tx with only metadata - [x] Tx with only withdrawal from self and external - [x] Only single output tx ⚠️ `pending` - outputs are empty - [x] Only multi-output tx ⚠️ `pending` - outputs are empty - [x] Multi asset transactions ⚠️ `pending` - outputs are empty - [x] Join and quit pool - join ⚠️ `pending` - deposits are empty - quit ⚠️ `pending` - can quit when you didn't join - errMsg404NoSuchPool ⚠️ `pending` - error not returned when should be - [ ] ~Minting~ - [x] validate_interval on different transactions (payments, delegations, mint) - invalid_before / invalid_hereafter ⚠️ `pending` - can be < 0 but shouldn't - [x] Transaction with all (payments, delegations, mint, metadata, withdrawal, validate_interval) # Comments / Issues - Should construct ep return `200` instead of `202` (coin selection returns `200`) - `amount` field would be probably handy to have in the response - Output field on response is empty (`"output": []`) on payment transactions, which seems like a bug (to be addressed in ADP-985)... for now tests marked as `pendingWith` - Deposit is empty on construct tx response on joining pool and shouldn't - You can quit pool before even joining - errMsg404NoSuchPool is not returned when trying to join absent pool Co-authored-by: Piotr Stachyra <[email protected]>

iohk-bors · 2021-07-07T12:52:07Z

Build failed:

buildkite/cardano-wallet

#expected

piotr-iohk · 2021-07-07T13:28:40Z

bors r+

2751: More integration tests for construct tx endpoint r=piotr-iohk a=piotr-iohk # Issue Number ADP-909 # Overview Integration tests covering: - [x] More malformed examples - [x] Only validate_interval - [x] Tx with only metadata - [x] Tx with only withdrawal from self and external - [x] Only single output tx ⚠️ `pending` - outputs are empty - [x] Only multi-output tx ⚠️ `pending` - outputs are empty - [x] Multi asset transactions ⚠️ `pending` - outputs are empty - [x] Join and quit pool - join ⚠️ `pending` - deposits are empty - quit ⚠️ `pending` - can quit when you didn't join - errMsg404NoSuchPool ⚠️ `pending` - error not returned when should be - [ ] ~Minting~ - [x] validate_interval on different transactions (payments, delegations, mint) - invalid_before / invalid_hereafter ⚠️ `pending` - can be < 0 but shouldn't - [x] Transaction with all (payments, delegations, mint, metadata, withdrawal, validate_interval) # Comments / Issues - Should construct ep return `200` instead of `202` (coin selection returns `200`) - `amount` field would be probably handy to have in the response - Output field on response is empty (`"output": []`) on payment transactions, which seems like a bug (to be addressed in ADP-985)... for now tests marked as `pendingWith` - Deposit is empty on construct tx response on joining pool and shouldn't - You can quit pool before even joining - errMsg404NoSuchPool is not returned when trying to join absent pool Co-authored-by: Piotr Stachyra <[email protected]>

rvl

LGTM - thanks.

rvl · 2021-07-07T13:40:51Z

lib/core-integration/src/Test/Integration/Scenario/API/Shelley/TransactionsNew.hs

+    it "TRANS_NEW_CREATE_01b - Validity interval only is not allowed" $ \ctx -> runResourceT $ do
+        wa <- fixtureWallet ctx
+        let validityInterval = Json [json|{
+                "validity_interval": {


@paweljakubas We should also add a simple validation (invalid before <= invalid hereafter) of the validity interval to the API JSON parser.

rvl · 2021-07-07T13:44:28Z

lib/core-integration/src/Test/Integration/Scenario/API/Shelley/TransactionsNew.hs

+        let payload = Json [json|{
+                "withdrawal": "self",
+                "validity_interval": {
+                    "invalid_before": "unspecified",


It should be that omission of the interval bound, or just setting it to null means "unspecified" -- no need to use a special string.

rvl · 2021-07-07T13:45:56Z

specifications/api/swagger.yaml

@@ -1363,7 +1363,7 @@ x-transactionTTL: &transactionTTL
 x-unspecified: &unspecified
  type: string
  enum:
-    - uspecified
+    - unspecified


@paweljakubas we should remove this "unspecified" and use null/undefined/missing to denote unspecified.

Yes, we've discussed this with Paweł and for now just added some tests (also covering other "failing" scenarios) and make them "pending"), such that then can be enabled later once the issues are fixed. Findings also listed here -> https://jira.iohk.io/browse/ADP-909.

iohk-bors · 2021-07-07T14:09:22Z

Build failed:

buildkite/cardano-wallet

#expected (hlint)

piotr-iohk · 2021-07-07T14:31:27Z

bors r+

iohk-bors · 2021-07-07T16:00:33Z

Build succeeded:

piotr-iohk self-assigned this Jul 5, 2021

piotr-iohk added the TESTS Adding additional tests label Jul 5, 2021

piotr-iohk force-pushed the piotr/testing-construct-tx-ep branch from e40bef5 to c66f572 Compare July 6, 2021 10:56

piotr-iohk requested a review from paweljakubas July 6, 2021 15:59

paweljakubas approved these changes Jul 7, 2021

View reviewed changes

Piotr Stachyra added 4 commits July 7, 2021 14:34

Construct tx:

b94e2f0

- single/multi payments - assets payments - metadata - withdrawals - invalid payloads

Construct tx: delegations

3a9fc29

Construct tx: validity_interval and multi tx

723ff3d

ApiConstructTransactionData: more malformed examples

88b5e7d

piotr-iohk force-pushed the piotr/testing-construct-tx-ep branch from ebda326 to f95f65e Compare July 7, 2021 12:38

piotr-iohk force-pushed the piotr/testing-construct-tx-ep branch from f95f65e to ad9cd19 Compare July 7, 2021 13:27

rvl approved these changes Jul 7, 2021

View reviewed changes

Test for validity_interval 'unspecified'

3567a08

piotr-iohk force-pushed the piotr/testing-construct-tx-ep branch from ad9cd19 to 3567a08 Compare July 7, 2021 14:14

iohk-bors bot merged commit 4222028 into master Jul 7, 2021

iohk-bors bot deleted the piotr/testing-construct-tx-ep branch July 7, 2021 16:00

WilliamKingNoel-Bot pushed a commit that referenced this pull request Jul 7, 2021

docs: Merge #2751

b7ebd60

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More integration tests for construct tx endpoint #2751

More integration tests for construct tx endpoint #2751

piotr-iohk commented Jul 5, 2021 •

edited

Loading

paweljakubas left a comment

piotr-iohk commented Jul 7, 2021

iohk-bors bot commented Jul 7, 2021 •

edited by piotr-iohk

Loading

piotr-iohk commented Jul 7, 2021

iohk-bors bot commented Jul 7, 2021 •

edited by Anviking

Loading

piotr-iohk commented Jul 7, 2021

rvl left a comment

rvl Jul 7, 2021

rvl Jul 7, 2021

rvl Jul 7, 2021

piotr-iohk Jul 7, 2021

iohk-bors bot commented Jul 7, 2021 •

edited by Anviking

Loading

piotr-iohk commented Jul 7, 2021

iohk-bors bot commented Jul 7, 2021

More integration tests for construct tx endpoint #2751

More integration tests for construct tx endpoint #2751

Conversation

piotr-iohk commented Jul 5, 2021 • edited Loading

Issue Number

Overview

Comments / Issues

paweljakubas left a comment

Choose a reason for hiding this comment

piotr-iohk commented Jul 7, 2021

iohk-bors bot commented Jul 7, 2021 • edited by piotr-iohk Loading

piotr-iohk commented Jul 7, 2021

iohk-bors bot commented Jul 7, 2021 • edited by Anviking Loading

piotr-iohk commented Jul 7, 2021

rvl left a comment

Choose a reason for hiding this comment

rvl Jul 7, 2021

Choose a reason for hiding this comment

rvl Jul 7, 2021

Choose a reason for hiding this comment

rvl Jul 7, 2021

Choose a reason for hiding this comment

piotr-iohk Jul 7, 2021

Choose a reason for hiding this comment

iohk-bors bot commented Jul 7, 2021 • edited by Anviking Loading

piotr-iohk commented Jul 7, 2021

iohk-bors bot commented Jul 7, 2021

piotr-iohk commented Jul 5, 2021 •

edited

Loading

iohk-bors bot commented Jul 7, 2021 •

edited by piotr-iohk

Loading

iohk-bors bot commented Jul 7, 2021 •

edited by Anviking

Loading

iohk-bors bot commented Jul 7, 2021 •

edited by Anviking

Loading