Implement ability to list addresses in the wallet layer, API and CLI #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akegalj
reviewed
May 16, 2019
| -- | ||
| -- NOTE: Change addresses aren't considered "known" until they've been used. The | ||
| -- rationale is that, we don't want users or consumers of the wallet to be using | ||
| -- change addresses primaturely. |
akegalj
reviewed
May 16, 2019
| @@ -119,6 +119,14 @@ specWithCluster = do | |||
| err `shouldBe` "Ok.\n" | |||
| out `shouldNotContain` "CLI Wallet" | |||
| c `shouldBe` ExitSuccess | |||
|
|
|||
| it "CLI - Can list addresses" $ \ctx -> do | |||
| walId <- createWallet ctx "CLI Wallet" mnemonics15 | |||
There was a problem hiding this comment.
why don't we also generate mnemonics here?
There was a problem hiding this comment.
Hmmm. Good question. No particular reasons that I can think of.
akegalj
reviewed
May 16, 2019
| :: (SeqState DummyTarget, ShowFmt Address, ShowFmt Address) | ||
| -> Property | ||
| prop_compareAntiSymmetric (s, ShowFmt a1, ShowFmt a2) = | ||
| fst (isOurs a1 s) && fst (isOurs a2 s) ==> cover 90 (a1 /= a2) "a1 /= a2" prop |
There was a problem hiding this comment.
I wonder what is distribution to pick two isOurs wallets (hopefully precondition won't take too long - depending on the generator)
There was a problem hiding this comment.
1) Cardano.Wallet.Primitive.AddressDiscovery.CompareDiscovery compareDiscovery is anti-symmetric
*** Gave up! Passed only 199 tests; 232 discarded tests (98.5% a1 /= a2).
almost :P
There was a problem hiding this comment.
Ho damn :o ! The coverage is too tight maybe here ^^"
KtorZ
force-pushed
the
KtorZ/220/list-addresses
branch
from
eb0601a to
d736dd4
Compare
KtorZ
force-pushed
the
KtorZ/220/list-addresses
branch
from
d736dd4 to
df4fb03
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 17, 2019
274: Implement ability to list addresses in the wallet layer, API and CLI r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #220 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [ ] I have implemented the ability to list addresses in the wallet layer, API and CLI # Comments <!-- Additional comments or screenshots to attach if any --> This would make it easier for @piotr-iohk and us to write some integration tests for the transaction API. We could have derived addresses by hand, but this achieves to complete the high-priority endpoints of the API. NOTE: It's a "partial" implementation which for now, ignores the filtering based on the address state (`?state=used` or `?state=unused`). This can be implemented later. :warning: I recommend looking at the change commit by commit ;) <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> 275: Docs, polish and config param 16 r=KtorZ a=Anviking # Issue Number #218 # Overview - [x] Appropriated some doc comments from the [list of config params](https://github.com/input-output-hk/rust-cardano/blob/master/chain-impl-mockchain/doc/format.md) - [x] Added missing `KesUpdateSpeed ` parameter - [x] Added `ConsensusVersion` data-type - [x] Some other super-minor polish # Comments <!-- Additional comments or screenshots to attach if any -->⚠️ the base is temporarily not `master`⚠️ <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]> Co-authored-by: Johannes Lund <[email protected]>
Timed out (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
May 17, 2019
274: Implement ability to list addresses in the wallet layer, API and CLI r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #220 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [ ] I have implemented the ability to list addresses in the wallet layer, API and CLI # Comments <!-- Additional comments or screenshots to attach if any --> This would make it easier for @piotr-iohk and us to write some integration tests for the transaction API. We could have derived addresses by hand, but this achieves to complete the high-priority endpoints of the API. NOTE: It's a "partial" implementation which for now, ignores the filtering based on the address state (`?state=used` or `?state=unused`). This can be implemented later. :warning: I recommend looking at the change commit by commit ;) <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]>
Timed out |
paweljakubas
approved these changes
May 17, 2019
| -> Property | ||
| prop_compareKnownUnknown (s, ShowFmt known, ShowFmt addr) = | ||
| case (fst $ isOurs known s, fst $ isOurs addr s) of | ||
| (True, False) -> cover 10 True "known-unknown" $ prop LT |
There was a problem hiding this comment.
this one along with prop_compareAntiSymmetric will check known-unknow and unknow-know. know-know will be covered by the aforementioned property. The missing one is unknow-unknow although very obvious one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#220
Overview
Comments
This would make it easier for @piotr-iohk and us to write some integration tests for the transaction API. We could have derived addresses by hand, but this achieves to complete the high-priority endpoints of the API.
NOTE: It's a "partial" implementation which for now, ignores the filtering based on the address state (
?state=usedor?state=unused). This can be implemented later.