-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GHC version from 8.10.4 -> 8.10.5 #2738
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 556e926.
It prevents using cached builds from nixpkgs and Haskell.nix.
hamishmack
approved these changes
Jul 7, 2021
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 8, 2021
2738: Update GHC version from 8.10.4 -> 8.10.5 r=rvl a=rvl ### Ticket ADP-952 ### Overview The next release of cardano-node will be on GHC 8.10.5, so we should also upgrade. - [x] Updates GHC to the latest minor release with bug fixes, etc. - [x] Also updates some build tool versions. - [x] Fix new HLint warnings coming from the new version. - [x] Fix `ApiAsset` JSON roundtrip encoding test, which seems to have stopped working (⇒ whitespace difference due to manual editing of golden json). - [x] Resolve Haskell.nix/Hydra issue with intermittent build failures due to missing `package.conf.d/*.conf` in library derivations (see input-output-hk/haskell.nix#956) (⇒ is working for the time being). - [x] Fix windows builds failing due to `readline` compilation error (⇒ wrong nixpkgs pin). - [x] Switch nixpkgs pin from iohk-nix default (`nixos-unstable` branch) to Haskell.nix default (`nixpkgs-unstable` branch)/ ### Comments [Hydra jobset](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-2738#tabs-evaluations) Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed: #expected - fixed here: input-output-hk/iohk-nix#484 |
This is using the branch from PR input-output-hk/iohk-nix#484.
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ADP-952
Overview
The next release of cardano-node will be on GHC 8.10.5, so we should also upgrade.
ApiAsset
JSON roundtrip encoding test, which seems to have stopped working (⇒ whitespace difference due to manual editing of golden json).package.conf.d/*.conf
in library derivations (see Check that the library component package.conf.d/*.conf file is created input-output-hk/haskell.nix#956) (⇒ is working for the time being).readline
compilation error (⇒ wrong nixpkgs pin).nixos-unstable
branch) to Haskell.nix default (nixpkgs-unstable
branch)/nixos-unstable
compatibility.Comments
Hydra jobset