Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GHC version from 8.10.4 -> 8.10.5 #2738

Merged
merged 17 commits into from
Jul 10, 2021
Merged

Update GHC version from 8.10.4 -> 8.10.5 #2738

merged 17 commits into from
Jul 10, 2021

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Jun 25, 2021

Ticket

ADP-952

Overview

The next release of cardano-node will be on GHC 8.10.5, so we should also upgrade.

  • Updates GHC to the latest minor release with bug fixes, etc.
  • Also updates some build tool versions.
  • Fix new HLint warnings coming from the new version.
  • Fix ApiAsset JSON roundtrip encoding test, which seems to have stopped working (⇒ whitespace difference due to manual editing of golden json).
  • Resolve Haskell.nix/Hydra issue with intermittent build failures due to missing package.conf.d/*.conf in library derivations (see Check that the library component package.conf.d/*.conf file is created input-output-hk/haskell.nix#956) (⇒ is working for the time being).
  • Fix windows builds failing due to readline compilation error (⇒ wrong nixpkgs pin).
  • Switch nixpkgs pin from iohk-nix default (nixos-unstable branch) to Haskell.nix default (nixpkgs-unstable branch)/
  • Use PR checkStackProject: Let it work with nixpkgs-unstable input-output-hk/iohk-nix#484 branch for nixos-unstable compatibility.
  • Replace crypto overlay from iohk-nix because it prevents a lot of caching.

Comments

Hydra jobset

@rvl rvl requested a review from hamishmack June 25, 2021 01:59
@rvl rvl self-assigned this Jun 25, 2021
@rvl rvl force-pushed the rvl/ghc-8.10.5 branch from 4b8a66c to 959bb96 Compare July 1, 2021 02:38
@rvl rvl force-pushed the rvl/ghc-8.10.5 branch from d9e2b57 to 65a24b4 Compare July 6, 2021 06:05
@rvl rvl force-pushed the rvl/ghc-8.10.5 branch from bbf47a5 to 5eb7b74 Compare July 7, 2021 07:55
@rvl
Copy link
Contributor Author

rvl commented Jul 8, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 8, 2021
2738: Update GHC version from 8.10.4 -> 8.10.5 r=rvl a=rvl

### Ticket

ADP-952

### Overview

The next release of cardano-node will be on GHC 8.10.5, so we should also upgrade.

- [x] Updates GHC to the latest minor release with bug fixes, etc.
- [x] Also updates some build tool versions.
- [x] Fix new HLint warnings coming from the new version.
- [x] Fix `ApiAsset` JSON roundtrip encoding test, which seems to have stopped working (⇒ whitespace difference due to manual editing of golden json).
- [x] Resolve Haskell.nix/Hydra issue with intermittent build failures due to missing `package.conf.d/*.conf` in library derivations (see input-output-hk/haskell.nix#956) (⇒ is working for the time being).
- [x] Fix windows builds failing due to `readline` compilation error (⇒ wrong nixpkgs pin).
- [x] Switch nixpkgs pin from iohk-nix default (`nixos-unstable` branch) to Haskell.nix default (`nixpkgs-unstable` branch)/

### Comments

[Hydra jobset](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-2738#tabs-evaluations)


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 8, 2021

Build failed:

#expected - fixed here: input-output-hk/iohk-nix#484

@rvl
Copy link
Contributor Author

rvl commented Jul 10, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 10, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 5b4d3e2 into master Jul 10, 2021
@iohk-bors iohk-bors bot deleted the rvl/ghc-8.10.5 branch July 10, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants