LoggingSpec: Fix error handling and remove problem test cases

[rvl]

Issue Number

ADP-562
ADP-1008

Overview

The test cases were getting stuck if ever there was an exception while setting up the warp server.
A common reason for this could be that the random port which was selected is no longer available.

Also I am removing the two tests which have caused so much flakiness, because we are pretty confident that the code works and will continue to work.

• Handle errors in the warp server setup.
• Delete the problem test cases.
• Re-enable these tests on macos.
• Fix some Haddock syntax errors that HLS wanted to tell me about.

[Anviking]

LGTM. I don't think this fixes our #2472 problems, but still great!

[Anviking]

bors r+

[Anviking]

So this should fix #2368 (trivially, by removing the property), and make the failure reason for #2217 clearer, I think.

[Anviking]

I don't think this fixes our #2472 problems

In support of that belief, a failure on this PR:

https://hydra.iohk.io/build/6735052

Coverage checks for generators
    TokenQuantity
      +++ OK, passed 100 tests:
      39% token quantity is massive
      27% token quantity is large
      20% token quantity is small
      14% token quantity is zero
Cardano.Wallet.DB.Sqlite
  State machine test (SeqState 'Mainnet ShelleyKey)
    Validate generators & shrinkers
      Generator for CreateWallet
      Shrinker for CreateWallet
      Generator for RemoveWallet
      Shrinker for RemoveWallet
      Generator for ListWallets
      Shrinker for ListWallets
      Generator for PutCheckpoints
      Shrinker for PutCheckpoints
      Generator for ReadCheckpoint
      Shrinker for ReadCheckpoint
      Generator for ListCheckpoints
      Shrinker for ListCheckpoints
      Generator for PutWalletMeta
      Shrinker for PutWalletMeta
      Generator for ReadWalletMeta
      Shrinker for ReadWalletMeta
      Generator for PutDelegationCertificate
      Shrinker for PutDelegationCertificate
      Generator for IsStakeKeyRegistered
      Shrinker for IsStakeKeyRegistered
      Generator for PutTxHistory
      Shrinker for PutTxHistory
      Generator for ReadTxHistory
      Shrinker for ReadTxHistory
      Generator for ReadLocalTxSubmissionPending
      Shrinker for ReadLocalTxSubmissionPending
      Generator for UpdatePendingTxForExpiry
      Shrinker for UpdatePendingTxForExpiry
      Generator for RemovePendingOrExpiredTx
      Shrinker for RemovePendingOrExpiredTx
      Generator for PutPrivateKey
      Shrinker for PutPrivateKey
      Generator for ReadPrivateKey
      Shrinker for ReadPrivateKey
      Generator for RollbackTo
      Shrinker for RollbackTo
      Generator for ReadGenesisParameters
      Shrinker for ReadGenesisParameters
building of '/nix/store/wgf2560pp44yhdlnlxb02k2djgy7gf6s-cardano-wallet-core-test-unit-2021.6.11-check' timed out after 900 seconds of silence

[iohk-bors]

Build succeeded:

• ci/hydra-build:required
• buildkite/cardano-wallet

[rvl]

Yep. The more flaky tests we fix, the easier things get.