-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require more recent version of hspec
(>= 2.8.2).
#2726
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
force-pushed
the
jonathanknowles/upgrade-hspec
branch
from
June 18, 2021 10:56
1f239c8
to
fce6720
Compare
rvl
approved these changes
Jun 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat
That version of hspec will require an index-state update. |
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 21, 2021
2726: Require more recent version of `hspec` (>= 2.8.2). r=jonathanknowles a=jonathanknowles # Issue Number ADP-978 # Overview This PR upgrades `hspec` to a more recent version that supports the following options: * `--times` prints an execution time for each individual spec. * `--print-slow-items[=n]` prints the `n` slowest spec items at the end of a test run. Co-authored-by: Jonathan Knowles <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed: #expected |
rvl
force-pushed
the
jonathanknowles/upgrade-hspec
branch
from
June 21, 2021 12:03
fce6720
to
9df941a
Compare
So that we have the latest Hackage data, without needing to bump Haskell.nix.
rvl
force-pushed
the
jonathanknowles/upgrade-hspec
branch
from
June 22, 2021 03:14
18f158c
to
831eb0f
Compare
... to fix a build error.
Version 1.0.0.0 started failing with the new Haskell.nix rev, because previous cabal.project build fixes were removed.
rvl
force-pushed
the
jonathanknowles/upgrade-hspec
branch
from
June 22, 2021 04:49
097b206
to
96c29ec
Compare
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-978
Overview
This PR upgrades
hspec
to a more recent version that supports the following options:--times
prints an execution time for each individual spec.--print-slow-items[=n]
prints then
slowest spec items at the end of a test run.