Make test cluster epoch length twice as long #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
In some stake pool tests we use `waitForNextEpoch` to ensure some requests and assertions occur within the same epoch. Recent reward-related CI failures suggest that they experience an epoch changes regardless. To try to alleviate the problem, this commits doubles the epoch length. The downside is that tests could take longer. With -j 6 locally I see no meaningful regression. With -j 3 in CI there could maybe be, but if it provides better stability it would be worth it regardless.
Anviking
force-pushed
the
anviking/ADP-979/double-epoch-length
branch
from
1bb9ea9 to
9bf8eea
Compare
tryBuild failed: |
|
bors try |
tryBuild succeeded: |
|
bors try |
tryBuild succeeded: |
rvl
approved these changes
Jun 10, 2021
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 10, 2021
2698: Make test cluster epoch length twice as long r=rvl a=Anviking # Issue Number <!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. --> ADP-979 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Make epoch length twice as long to help epoch-sensitive tests (see commit message) # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> Co-authored-by: Johannes Lund <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
This was referenced Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-979
Overview
Comments