Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout earlier on SQLITE_BUSY when deleting wallets in tests #2696

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Timeout earlier on SQLITE_BUSY when deleting wallets in tests #2696

merged 2 commits into from
Jun 10, 2021

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Jun 9, 2021 •
edited
Loading

Issue Number

ADP-827

Overview

  • Set CARDANO_WALLET_INTEGRATION env var in integration tests
  • Change timeout to close all connections from 60s to 2s if CARDANO_WALLET_INTEGRATION is set.

Comments

  • Workaround that should make CI faster (and perhaps a bit more stable), until we have time to investigate and address the underlying issue and its effects in production. The problem in production is likely much less serious, as users likely don't create and delete wallets as often as in our integration tests.
  • Locally, running stack test cardano-wallet:integration --ta '-j 6' I get:
    • 2s -> 335s
    • 5s -> 380s
    • 60s (without the setEnv) -> 1190s

So that's why I went with 2s rather than 5s.

@Anviking Anviking requested a review from rvl June 9, 2021 10:56
@Anviking Anviking self-assigned this Jun 9, 2021
@Anviking Anviking force-pushed the anviking/ADP-827/delete-timeout branch from 18f5e2a to 8a9b48e Compare June 9, 2021 19:14
@Anviking Anviking force-pushed the anviking/ADP-827/delete-timeout branch from 8a9b48e to a9f46dd Compare June 9, 2021 19:15
rvl
rvl approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Anviking - this should hopefully improve the integration tests.

@rvl rvl force-pushed the anviking/ADP-827/delete-timeout branch from 2cc7b05 to 40428f4 Compare June 10, 2021 06:24
@rvl
Copy link
Contributor

rvl commented Jun 10, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request Jun 10, 2021
@iohk-bors @Anviking @rvl
Merge #2696 #2697
babfe62 
2696: Timeout earlier on SQLITE_BUSY when deleting wallets in tests r=rvl a=Anviking

# Issue Number

ADP-827

# Overview

- [x] Set `CARDANO_WALLET_INTEGRATION` env var in integration tests
- [x] Change timeout to close all connections from `60s` to `2s` if `CARDANO_WALLET_INTEGRATION` is set.


# Comments

- Workaround that should make CI faster (and perhaps a bit more stable), until we have time to investigate and address the underlying issue and its effects in production. The problem in production is likely much less serious, as users likely don't create and delete wallets as often as in our integration tests.
- Locally, running `stack test cardano-wallet:integration --ta '-j 6'` I get:
    - 2s -> 335s
    - 5s -> 380s
    - 60s (without the `setEnv`) -> 1190s

So that's why I went with 2s rather than 5s.

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


2697: E2E golden tests cardano-wallet vs. cardano-addresses account xpub (including purpose) r=rvl a=piotr-iohk



# Issue Number

ADP-950


# Overview

- 0ded5ef
  E2E golden tests cardano-wallet vs. cardano-addresses account xpub (including purpose)


# Comments

While testing purpose addition to https://input-output-hk.github.io/cardano-wallet/api/edge/#operation/postAccountKey endpoint I have extended existing e2e tests to assert if the returned keys are the same as produced by cardano-addresses.


Co-authored-by: Johannes Lund <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 10, 2021 •
edited by Anviking
Loading

Build failed (retrying...):

  src/Test/Integration/Scenario/API/Shelley/Migrations.hs:926:23:
  1) API Specifications, SHELLEY_MIGRATIONS, SHELLEY_MIGRATE_08 - It's possible to migrate a wallet with many small ada quantities, provided that the total balance is significantly greater than the minimum ada quantity for an output.
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiUtxoStatistics {total = Quantity {getQuantity = 0}, scale = ApiT {getApiT = Log10}, distribution = fromList [(10,0),(100,0),(1000,0),(10000,0),(100000,0),(1000000,0),(10000000,0),(100000000,0),(1000000000,0),(10000000000,0),(100000000000,0),(1000000000000,0),(10000000000000,0),(100000000000000,0),(1000000000000000,0),(10000000000000000,0),(45000000000000000,0)]}))
       expected: [(100000000,1)]
        but got: []

#2699

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 10, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit a7f6afa into master Jun 10, 2021
@iohk-bors iohk-bors bot deleted the anviking/ADP-827/delete-timeout branch June 10, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anviking @rvl