Factor getAccountBalance into getCachedAccountBalance and fetchAccountBalances

[Anviking]

Issue Number

Split off from #2684

Overview

• Rename getAccountBalance to getCachedAccountBalance for clarity
• Add fetchAccountBalances function for un-cached behaviour
• fetchAccountBalances from listStakeKeys

Comments

[paweljakubas]

occasionally I think that fetchRewardAccountBalances and getCachedRewardAccountBalance would be better here in spite of being long...

[Anviking]

👍 fair -> d81089b

[paweljakubas]

I like this decomposition. If we have a proof that it helps with flaky integration testing then it is great

[Anviking]

Thanks for having a look.

If we have a proof that it helps with flaky integration testing then it is great

This wasn't intended to fix flaky tests, although that's a good point, this caching-behaviour could be involved 🤔

(This PR only changes the behaviour of listStakeKeys. Wallet reward balances still use the cached version.)

[Anviking]

bors r+

[iohk-bors]

Build failed (retrying...):

• buildkite/cardano-wallet
  #expected

[Anviking]

bors r-

[iohk-bors]

Canceled.

[Anviking]

bors r+

[iohk-bors]

Build failed:

• ci/hydra-build:required

  src/Test/Integration/Framework/DSL.hs:2275:7:
  1) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_JOIN_01rewards - Can join a pool, earn rewards and collect them
       expected a successful response but got an error: DecodeFailure "{\"code\":\"created_invalid_transaction\",\"message\":\"That's embarrassing. It looks like I've created an invalid transaction that could not be parsed by the node. Here's an error message that may help with debugging: HardForkApplyTxErrFromEra S (S (S (Z (WrapApplyTxErr {unwrapApplyTxErr = ApplyTxError [DelegsFailure (WithdrawalsNotInRewardsDELEGS (fromList [(RewardAcnt {getRwdNetwork = Mainnet, getRwdCred = KeyHashObj (KeyHash \\\"2bde53d335518b59732afbeb458aab9e869c4781735c19852aacaa30\\\")},Coin 496746603)]))]}))))\"}"
       While verifying (Status {statusCode = 500, statusMessage = "Internal Server Error"},Left (DecodeFailure "{\"code\":\"created_invalid_transaction\",\"message\":\"That's embarrassing. It looks like I've created an invalid transaction that could not be parsed by the node. Here's an error message that may help with debugging: HardForkApplyTxErrFromEra S (S (S (Z (WrapApplyTxErr {unwrapApplyTxErr = ApplyTxError [DelegsFailure (WithdrawalsNotInRewardsDELEGS (fromList [(RewardAcnt {getRwdNetwork = Mainnet, getRwdCred = KeyHashObj (KeyHash \\\"2bde53d335518b59732afbeb458aab9e869c4781735c19852aacaa30\\\")},Coin 496746603)]))]}))))\"}"))

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_JOIN_01rewards - Can join a pool, earn rewards and collect them/"

Randomized with seed 567840892

#2415

[Anviking]

bors r+

[iohk-bors]

Build failed:

• ci/hydra-build:required

Failures:

  src/Test/Integration/Scenario/API/Shelley/Wallets.hs:988:26:
  1) API Specifications, SHELLEY_WALLETS, WALLETS_UTXO_02 - Sending and receiving funds updates wallet's utxo.
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiWallet {id = ApiT {getApiT = WalletId {getWalletId = b0d938dada1aa6c2bcd4de4786fcae0d035f0963}}, addressPoolGap = ApiT {getApiT = AddressPoolGap {getAddressPoolGap = 20}}, balance = ApiWalletBalance {available = Quantity {getQuantity = 0}, total = Quantity {getQuantity = 0}, reward = Quantity {getQuantity = 0}}, assets = ApiWalletAssetsBalance {available = ApiT {getApiT = TokenMap (fromList [])}, total = ApiT {getApiT = TokenMap (fromList [])}}, delegation = ApiWalletDelegation {active = ApiWalletDelegationNext {status = NotDelegating, target = Nothing, changesAt = Nothing}, next = []}, name = ApiT {getApiT = WalletName {getWalletName = "Empty Wallet"}}, passphrase = Just (ApiWalletPassphraseInfo {lastUpdatedAt = 2021-06-08 19:29:07.940773 UTC}), state = ApiT {getApiT = Syncing (Quantity {getQuantity = Percentage {getPercentage = 257 % 625}})}, tip = ApiBlockReference {absoluteSlotNumber = ApiT {getApiT = SlotNo 691}, slotId = ApiSlotId {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 13}}, slotNumber = ApiT {getApiT = SlotInEpoch {unSlotInEpoch = 41}}}, time = 2021-06-08 19:27:20.2 UTC, block = ApiBlockInfo {height = Quantity {getQuantity = 252}}}}))
       Waited longer than 90s to resolve action: "Wallet balance is as expected".
       expected: Quantity {getQuantity = 1562000000}
        but got: Quantity {getQuantity = 0}

  To rerun use: --match "/API Specifications/SHELLEY_WALLETS/WALLETS_UTXO_02 - Sending and receiving funds updates wallet's utxo./"

  src/Test/Integration/Scenario/API/Shelley/Wallets.hs:1346:57:
  2) API Specifications, SHELLEY_WALLETS, NETWORK_SHELLEY - Wallet has the same tip as network/information
       Waited longer than 90s to resolve action: "Wallet has the same tip as network/information".
       expected: Ready
        but got: Syncing (Quantity {getQuantity = Percentage {getPercentage = 497 % 1250}})

  To rerun use: --match "/API Specifications/SHELLEY_WALLETS/NETWORK_SHELLEY - Wallet has the same tip as network/information/"

Cascade of more and more failures (137 in total), starting with the above.

Wallet syncing problems, starting before WALLETS_UTXO_02 failed. But if they caused the failure, or the other way around.

#2720

[Anviking]

bors r+

[iohk-bors]

Build succeeded:

• ci/hydra-build:required
• buildkite/cardano-wallet