Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2e tests updates #2656

Merged
merged 3 commits into from
May 19, 2021
Merged

E2e tests updates #2656

merged 3 commits into from
May 19, 2021

Conversation

piotr-iohk
Copy link
Contributor

Issue Number

Overview

Comments

@piotr-iohk piotr-iohk self-assigned this May 18, 2021
paweljakubas
paweljakubas approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request May 18, 2021
@iohk-bors @paweljakubas
Merge #2650 #2656
1d639b3 
2650: List addresses and wallets for shared wallet r=paweljakubas a=paweljakubas

# Issue Number

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->

adp-686

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Extension to WalletStyle and Discrimination in Api.Link
- [x] Adding listSharedWallets with integration tests
- [x] Resign from getSharedWallet in Api.Link in favour of getWallet
- [x] Resign from deleteSharedWallet in Api.Link in favour of deleteWallet
- [x] Resign from postSharedWallet in Api.Link in favour of postWallet
- [x] add `normalizeSharedAddress`
- [x] add `KnownAddresses`  instance for `SharedState`
- [x] add `CompareDiscovery`  instance for `SharedState`
- [x] add listAddresses to shared wallet
- [x] add integration testing for listSharedAddresses
- [x] change `AddressDiscovery.SharedState` to `AddressDiscovery.Shared` 
- [x] enable UtxOInternal for ApiVerificationKeyShared


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


2656: E2e tests updates r=piotr-iohk a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

- 3345a88
  add decimals to HappyCoin
  
- 6fb310b
  update migration tests
  
- 097173b
  update construct key tests

# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Pawel Jakubas <[email protected]>
Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 18, 2021 •
edited by rvl
Loading

Build failed (retrying...):

Failures:

  src/Test/Integration/Scenario/API/Shelley/StakePools.hs:503:5: 
  1) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_JOIN_01 - Can rejoin another stakepool
       uncaught exception: IOException of type UserError
       user error (next delegation should contain exactly one element)

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_JOIN_01 - Can rejoin another stakepool/"

Randomized with seed 356351035

Finished in 1290.0902 seconds
788 examples, 1 failure, 15 pending
builder for '/nix/store/g973x2z4crl1xl2w37aaq95wr4482vaa-cardano-wallet-test-integration-2021.4.28-x86_64-unknown-linux-musl-check-x86_64-unknown-linux-musl.drv' failed with exit code 1

#2497

iohk-bors bot added a commit that referenced this pull request May 18, 2021
@iohk-bors
Merge #2656
7231de1 
2656: E2e tests updates r=piotr-iohk a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

- 3345a88
  add decimals to HappyCoin
  
- 6fb310b
  update migration tests
  
- 097173b
  update construct key tests

# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 18, 2021 •
edited by rvl
Loading

Build failed:

#2657

An interesting new CI failure.

@rvl
Copy link
Contributor

rvl commented May 19, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request May 19, 2021
@iohk-bors
Merge #2656
7836ebb 
2656: E2e tests updates r=rvl a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

- 3345a88
  add decimals to HappyCoin
  
- 6fb310b
  update migration tests
  
- 097173b
  update construct key tests

# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 19, 2021 •
edited by rvl
Loading

Build failed:

#2415

:rage1:

@rvl rvl merged commit 9f5fdf2 into master May 19, 2021
@rvl rvl deleted the piotr/e2e-tests-updates branch May 19, 2021 08:02
@piotr-iohk
Copy link
Contributor Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@piotr-iohk piotr-iohk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotr-iohk @rvl @paweljakubas