Add integration tests for migration of reward balances #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
force-pushed
the
jonathanknowles/migration-integration-tests-reward-balance
branch
from
f9be46c to
69d95c9
Compare
This integration test checks that it's possible to create a migration plan for a wallet that has rewards.
…withdrawal. For Shelley-era wallets, we specify `Just SelfWithdrawal`. For Byron-era wallets, we specify `Nothing`. In the case of Shelley-era wallets, this causes the full reward balance to always be included in the plan.
The node verifies that transactions are exactly balanced. Therefore, we can rely on the contents of the `fee` field of a successfully-submitted `ApiTransaction` to be correct. The previous implementation was incorrect, as it failed to include the reward withdrawal in the fee calculation.
In this test, we check that it's possible to migrate a wallet that has rewards.
…awal. For Shelley-era wallets, we specify `Just SelfWithdrawal`. For Byron-era wallets, we specify `Nothing`. In the case of Shelley-era wallets, this causes the full reward balance to always be included in the plan, and the resultant transactions.
This echoes usage elsewhere, and clearly indicates that the selection results are expected to have no change.
jonathanknowles
force-pushed
the
jonathanknowles/migration-integration-tests-reward-balance
branch
from
69d95c9 to
d695cb0
Compare
Anviking
approved these changes
May 18, 2021
| . view #getQuantity | ||
| . view #amount | ||
| . head | ||
| . view #withdrawals |
| ] | ||
|
|
||
| -- Check that the source wallet has been depleted: | ||
| eventually "Source wallet balance is depleted." $ do |
jonathanknowles
commented
May 18, 2021
| extraCoinSource = | ||
| if (view #rewardWithdrawal migrationSelection) > Coin 0 | ||
| then Just (view #rewardWithdrawal migrationSelection) | ||
| else Nothing |
There was a problem hiding this comment.
We should add a comment here explaining why this is necessary.
There was a problem hiding this comment.
Fixed in c3a8bfd.
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/migration-integration-tests-reward-balance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-840
Overview
This PR:
createMigrationPlan.(
CREATE_MIGRATION_PLAN_06)migrateWallet.(
MIGRATE_09)createMigrationPlanto require callers to specify a reward withdrawal method, which it passes tomkRewardAccountBuilder.(Previously it always passed
Nothing.)migrateWalletto require callers to specify a reward withdrawal method, which it passes tomkRewardAccountBuilder.(Previously it always passed
Nothing.)mkApiWalletMigrationPlanto include the reward withdrawal balance in thebalanceSelectedfield.(Previously the reward balance was omitted from the
balanceSelectedfield.