Add property tests for migrationPlanToSelectionWithdrawals.
#2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
force-pushed
the
jonathanknowles/test-migrationPlanToSelectionWithdrawals
branch
from
aa63bc8 to
5c1cd04
Compare
jonathanknowles
commented
May 17, 2021
| pidB = PoolId "B" | ||
| pidUnknown = PoolId "unknown" | ||
| knownPools = Set.fromList [pidA, pidB] | ||
| next = WalletDelegationNext |
There was a problem hiding this comment.
This where clause is a bit annoying: it should belong to the pool delegation tests, but its scope covers the entire property test suite for this module.
jonathanknowles
commented
May 17, 2021
| } | ||
| deriving (Generic, Eq, Ord) | ||
| deriving anyclass (NFData, Hashable) | ||
| deriving (Read, Show) via (Quiet Address) |
There was a problem hiding this comment.
This makes the output of show much more concise for values of type Address.
Instead of:
Address { unAddress = "XXXX" }We now have:
Address "XXXX"
This makes the output of `show` much more concise for values of type `Address`.
Instead of:
```hs
Address { unAddress = "XXXX" }
```
We now have:
```hs
Address "XXXX"
```
This commit makes `migrationPlanToSelectionWithdrawals` assign target addresses in an order that precisely matches the order specified by the user. For example, suppose the user specifies the following target addresses: >>> [a1, a2, a3] These addresses will be assigned to the generated outputs in the following predictable cyclic order: >>> [a1, a2, a3, a1, a2, a3, .. ]
…outputs. In particular, we test that inputs and outputs are preserved in the correct order.
jonathanknowles
force-pushed
the
jonathanknowles/test-migrationPlanToSelectionWithdrawals
branch
from
5c1cd04 to
ff468a0
Compare
jonathanknowles
commented
May 17, 2021
Anviking
approved these changes
May 17, 2021
| @@ -1887,7 +1889,7 @@ migrationPlanToSelectionWithdrawals plan rewardWithdrawal outputAddressesToCycle | |||
|
|
|||
| outputAddressesRemaining :: [Address] | |||
| outputAddressesRemaining = | |||
| drop (length $ view #outputs migrationSelection) outputAddresses | |||
| drop (length outputsCovered) outputAddresses | |||
There was a problem hiding this comment.
Is this a fix, or is it equivalent?
There was a problem hiding this comment.
Is this a fix, or is it equivalent?
It's equivalent.
I guess, strictly speaking, this should be in a separate commit, as it isn't part of the fix. But it seems too minor to create a separate commit just for that.
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/test-migrationPlanToSelectionWithdrawals
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-840
Overview
This PR:
migrationPlanToSelectionWithdrawalsfunction.Background
Before this PR, the order in which target addresses were assigned to outputs was not cyclical, as expected: