Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing shared wallets #2651

Merged
merged 4 commits into from
May 17, 2021
Merged

Testing shared wallets #2651

merged 4 commits into from
May 17, 2021

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented May 13, 2021

Issue Number

ADP-866

Overview

  • 73225b4
    fix e2e tests to comply with purpose=1854' for multisig keys

  • c475917
    Tests for cosigner self

  • ed846f0
    Tests for public keys

  • 40698f4
    Tests for Account Public Keys

Comments

@piotr-iohk piotr-iohk self-assigned this May 13, 2021
end

it "Get public key - pending wallet from acc pub key" do
pending "utxo_internal returns empty response"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paweljakubas I've added tests covering the issue where utxo_internal returns empty response and tagged them pending for now...

end

it "Create account public key - pending wallet from acc pub key" do
pending 'no_root key error on wallet from acc pub key'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here for the fact that currently there is 'no_root key error' returned when trying to get acc pub key from wallets created from acc pub key.

@piotr-iohk piotr-iohk requested a review from paweljakubas May 14, 2021 14:15
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request May 17, 2021
2651: Testing shared wallets r=piotr-iohk a=piotr-iohk

# Issue Number

ADP-866


# Overview

- 73225b4
  fix e2e tests to comply with purpose=1854' for multisig keys
  
- c475917
  Tests for cosigner self
  
- ed846f0
  Tests for public keys
  
- 40698f4
  Tests for Account Public Keys
# Comments


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 17, 2021

Timed out.

@piotr-iohk
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 17, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 2c84173 into master May 17, 2021
@iohk-bors iohk-bors bot deleted the piotr/e2e-tests-shared-wallet-keys branch May 17, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants