Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Hydra eval #2645

Merged
merged 8 commits into from
May 13, 2021
Merged

Optimize Hydra eval #2645

merged 8 commits into from
May 13, 2021

Conversation

rvl
Copy link
Contributor

@rvl rvl commented May 10, 2021 •
edited
Loading

Issue Number

ADP-921

Overview

  • Copies the fix from Optimize Hydra Eval (rebased) IntersectMBO/cardano-node#2315 to reduce maximum memory usage of cardano-wallet evaluations.
  • The release jobset needed to be completely rearranged for the above fix.
  • Change the hydra "required" job constituents to be a list of string job names (instead of the actual derivations). This is supposed to make the aggregate build step quicker.
  • Add a github action to record build time metrics on a separate git branch.
  • Fix a windows release build job filename
  • Enable pretty-simple in .ghci config and nix-shell tweak.

Comments

@rvl rvl requested review from hamishmack and iohk-devops May 10, 2021 08:36
@rvl rvl self-assigned this May 10, 2021
@rvl rvl force-pushed the rvl/adp-921/optimize-hydra-eval branch from 9cdd018 to ce39230 Compare May 13, 2021 04:58
@rvl rvl requested a review from sevanspowell May 13, 2021 05:01
@rvl rvl force-pushed the rvl/adp-921/optimize-hydra-eval branch from ce39230 to 5507955 Compare May 13, 2021 05:54
sevanspowell
sevanspowell approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@sevanspowell sevanspowell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan 👍

Link to GitHub action: https://github.com/rvl/hydra-build-products-action

@rvl rvl force-pushed the rvl/adp-921/optimize-hydra-eval branch 2 times, most recently from 08e0210 to 160ff5a Compare May 13, 2021 09:23
@rvl
ci: Add GitHub action to collect build statistics
727dc4b 
Also reorganise the scripts used for workflows.
@rvl rvl force-pushed the rvl/adp-921/optimize-hydra-eval branch from 160ff5a to 727dc4b Compare May 13, 2021 12:08
@rvl
Copy link
Contributor Author

rvl commented May 13, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 13, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 284f260 into master May 13, 2021
@iohk-bors iohk-bors bot deleted the rvl/adp-921/optimize-hydra-eval branch May 13, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevanspowell sevanspowell sevanspowell approved these changes

@hamishmack hamishmack Awaiting requested review from hamishmack

@iohk-devops iohk-devops Awaiting requested review from iohk-devops

Assignees

@rvl rvl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvl @sevanspowell