Remove icarus genesis gap hack #2643

Anviking · 2021-05-07T11:45:21Z

Issue Number

ADP-828

Overview

Use the standard gap size, even for the genesis block.
Fund icarus fixture wallets using txs, not as part of the byron genesis
- Not entirely sure why this helped though 🤔 - the wallets only had 10 addresses, so the order shouldn't have mattered anyway...

Comments

Anviking · 2021-05-07T12:37:31Z

bors try

KtorZ

Yes! I am pretty sure there's also a special Icarus wallet with addresses starting only at a high index (like 500 or so) which would now fail because of this.

I think it's fine to get rid of this scenario now, since it was mainly for the ITN snapshot. @piotr-iohk, thoughts?

Don't fund icarus wallets in genesis This used to make ADDRESS_LIST_02 - Can filter used and unused addresses fail, presumably because the genesis entries didn't have any guaranteed order. Remove unused shrinkPool etc Remove BYRON_RESTORE_08

Anviking · 2021-05-07T13:20:30Z

bors try

iohk-bors · 2021-05-07T13:20:32Z

try

Already running a review

Anviking · 2021-05-07T13:20:44Z

bors try-

Anviking · 2021-05-07T13:30:52Z

I am pretty sure there's also a special Icarus wallet with addresses starting only at a high index (like 500 or so) which would now fail because of this.

👍

@piotr-iohk, thoughts?

I think Piotr is off until something like Wednesday. But I can't either see why the test would matter now, and he'll have the opportunity to object in the QA phase of the ticket too, so merging.

bors r+

2643: Remove icarus genesis gap hack r=Anviking a=Anviking # Issue Number ADP-828 # Overview  - [x] Use the standard gap size, even for the genesis block. - [x] Fund icarus fixture wallets using txs, not as part of the byron genesis - Not entirely sure why this helped though 🤔 - the wallets only had 10 addresses, so the order shouldn't have mattered anyway... # Comments   Co-authored-by: Johannes Lund <[email protected]>

iohk-bors · 2021-05-07T13:58:42Z

Build failed:

ci/hydra-build:required

[65 of 86] Compiling Data.Time.Text   ( src/Data/Time/Text.hs, dist/build/Data/Time/Text.o, dist/build/Data/Time/Text.dyn_o )
ld: warning: /nix/store/zzcxvnywlxhdbrnzszppv4xcjz1zjybf-libiconv-osx-10.12.6/lib/libiconv.dylib, ignoring unexpected dylib file
ld: warning: /nix/store/zzcxvnywlxhdbrnzszppv4xcjz1zjybf-libiconv-osx-10.12.6/lib/libiconv.dylib, ignoring unexpected dylib file
[66 of 86] Compiling Cardano.Wallet.Api.Types ( src/Cardano/Wallet/Api/Types.hs, dist/build/Cardano/Wallet/Api/Types.o, dist/build/Cardano/Wallet/Api/Types.dyn_o )
building of '/nix/store/q0vmm6gjpw2phzjdg4aj0m7yfd18ay1q-cardano-wallet-core-lib-cardano-wallet-core-2021.4.28' timed out after 900 seconds of silence

New one - the build times out. But
#expected
integration failure too.

Anviking · 2021-05-07T14:01:14Z

bors r+

2643: Remove icarus genesis gap hack r=Anviking a=Anviking # Issue Number ADP-828 # Overview  - [x] Use the standard gap size, even for the genesis block. - [x] Fund icarus fixture wallets using txs, not as part of the byron genesis - Not entirely sure why this helped though 🤔 - the wallets only had 10 addresses, so the order shouldn't have mattered anyway... # Comments   Co-authored-by: Johannes Lund <[email protected]>

iohk-bors · 2021-05-07T14:36:25Z

Build failed:

buildkite/cardano-wallet

#expected

The fixture wallets now have 1 instead of 10 txs.

Anviking · 2021-05-07T16:20:13Z

bors r+

2643: Remove icarus genesis gap hack r=Anviking a=Anviking # Issue Number ADP-828 # Overview  - [x] Use the standard gap size, even for the genesis block. - [x] Fund icarus fixture wallets using txs, not as part of the byron genesis - Not entirely sure why this helped though 🤔 - the wallets only had 10 addresses, so the order shouldn't have mattered anyway... # Comments   Co-authored-by: Johannes Lund <[email protected]>

iohk-bors · 2021-05-07T17:28:58Z

Build failed:

ci/hydra-build:required

Cardano.Wallet.DB.Sqlite.Types
  Values can be persisted and unpersisted successfully
    can persist and unpersist values of type 'SlotNo'
      +++ OK, passed 100 tests.
    can persist and unpersist values of type 'NominalDiffTime'
      +++ OK, passed 100 tests.
    can persist and unpersist values of type 'TokenQuantity'
      +++ OK, passed 100 tests.
  Coverage checks for generators
    TokenQuantity
      +++ OK, passed 100 tests:
building of '/nix/store/gkds2as2iwlxq1x9yxvyihgcy1ii5112-cardano-wallet-core-test-unit-2021.4.28-check' timed out after 900 seconds of silence

#2472

Anviking · 2021-05-07T18:09:25Z

bors r+

2643: Remove icarus genesis gap hack r=Anviking a=Anviking # Issue Number ADP-828 # Overview  - [x] Use the standard gap size, even for the genesis block. - [x] Fund icarus fixture wallets using txs, not as part of the byron genesis - Not entirely sure why this helped though 🤔 - the wallets only had 10 addresses, so the order shouldn't have mattered anyway... # Comments   Co-authored-by: Johannes Lund <[email protected]>

paweljakubas

lgmt

iohk-bors · 2021-05-07T18:48:02Z

Build failed:

ci/hydra-build:required

Failures:

  src/Test/Integration/Scenario/API/Byron/Wallets.hs:187:59: 
  1) API Specifications, BYRON_WALLETS, BYRON_RESTORE_01, GET_01, LIST_01 - Restore a wallet, ledger 18 words
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiByronWallet {id = ApiT {getApiT = WalletId {getWalletId = e814898be91c453b1103662e2d60b43a57a2460b}}, balance = ApiByronWalletBalance {available = Quantity {getQuantity = 0}, total = Quantity {getQuantity = 0}}, assets = ApiWalletAssetsBalance {available = ApiT {getApiT = TokenMap (fromList [])}, total = ApiT {getApiT = TokenMap (fromList [])}}, discovery = DiscoverySequential, name = ApiT {getApiT = WalletName {getWalletName = "Empty Byron Wallet"}}, passphrase = Just (ApiWalletPassphraseInfo {lastUpdatedAt = 2021-05-07 18:30:40.56883832 UTC}), state = ApiT {getApiT = Syncing (Quantity {getQuantity = Percentage {getPercentage = 2641 % 5000}})}, tip = ApiBlockReference {absoluteSlotNumber = ApiT {getApiT = SlotNo 2027}, slotId = ApiSlotId {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 40}}, slotNumber = ApiT {getApiT = SlotInEpoch {unSlotInEpoch = 27}}}, time = 2021-05-07 18:24:39.4 UTC, block = ApiBlockInfo {height = Quantity {getQuantity = 1000}}}}))
       Waited longer than 90s to resolve action: "wallet is available and ready".
[cardano-wallet.network:Warning:2014] [2021-05-07 18:47:59.09 UTC] Connection lost with the node. Network.Socket.recvBuf: resource vanished (Connection reset by peer)
       expected: Ready
        but got: Syncing (Quantity {getQuantity = Percentage {getPercentage = 2641 % 5000}})

  To rerun use: --match "/API Specifications/BYRON_WALLETS/BYRON_RESTORE_01, GET_01, LIST_01 - Restore a wallet/ledger 18 words/"

#2565

Anviking · 2021-05-07T18:51:32Z

bors r+

iohk-bors · 2021-05-07T19:26:52Z

Build succeeded:

iohk-bors bot added a commit that referenced this pull request May 7, 2021

Try #2643:

4c583c2

KtorZ approved these changes May 7, 2021

View reviewed changes

Anviking self-assigned this May 7, 2021

Anviking force-pushed the anviking/ADP-828/rm-ica-hack branch from 9fae748 to 3fc76c7 Compare May 7, 2021 13:18

Tweak expectation for Icarus version of BYRON_TX_LIST_01

014fd02

The fixture wallets now have 1 instead of 10 txs.

paweljakubas approved these changes May 7, 2021

View reviewed changes

iohk-bors bot merged commit 6814c0e into master May 7, 2021

iohk-bors bot deleted the anviking/ADP-828/rm-ica-hack branch May 7, 2021 19:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove icarus genesis gap hack #2643

Remove icarus genesis gap hack #2643

Anviking commented May 7, 2021 •

edited

Loading

Anviking commented May 7, 2021

KtorZ left a comment

Anviking commented May 7, 2021

iohk-bors bot commented May 7, 2021

Anviking commented May 7, 2021

Anviking commented May 7, 2021

iohk-bors bot commented May 7, 2021 •

edited by Anviking

Loading

Anviking commented May 7, 2021

iohk-bors bot commented May 7, 2021 •

edited by Anviking

Loading

Anviking commented May 7, 2021

iohk-bors bot commented May 7, 2021 •

edited by Anviking

Loading

Anviking commented May 7, 2021

paweljakubas left a comment

iohk-bors bot commented May 7, 2021 •

edited by Anviking

Loading

Anviking commented May 7, 2021

iohk-bors bot commented May 7, 2021

Remove icarus genesis gap hack #2643

Remove icarus genesis gap hack #2643

Conversation

Anviking commented May 7, 2021 • edited Loading

Issue Number

Overview

Comments

Anviking commented May 7, 2021

KtorZ left a comment

Choose a reason for hiding this comment

Anviking commented May 7, 2021

iohk-bors bot commented May 7, 2021

try

Anviking commented May 7, 2021

Anviking commented May 7, 2021

iohk-bors bot commented May 7, 2021 • edited by Anviking Loading

Anviking commented May 7, 2021

iohk-bors bot commented May 7, 2021 • edited by Anviking Loading

Anviking commented May 7, 2021

iohk-bors bot commented May 7, 2021 • edited by Anviking Loading

Anviking commented May 7, 2021

paweljakubas left a comment

Choose a reason for hiding this comment

iohk-bors bot commented May 7, 2021 • edited by Anviking Loading

Anviking commented May 7, 2021

iohk-bors bot commented May 7, 2021

Anviking commented May 7, 2021 •

edited

Loading

iohk-bors bot commented May 7, 2021 •

edited by Anviking

Loading

iohk-bors bot commented May 7, 2021 •

edited by Anviking

Loading

iohk-bors bot commented May 7, 2021 •

edited by Anviking

Loading

iohk-bors bot commented May 7, 2021 •

edited by Anviking

Loading