Integration test: Polling for wallet fixture & Better error handling #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…branch in 'request'
… necessary and be more reliable
KtorZ
commented
May 15, 2019
| , "--tlscert", "/dev/null" | ||
| , "--tlskey", "/dev/null" | ||
| , "--tlsca", "/dev/null" | ||
| , "--no-tls" |
There was a problem hiding this comment.
Apparently, even if we provide --no-tls, we still have to give all the --tls*** options to the node... undoubtedly nice CLI we have there.
KtorZ
commented
May 15, 2019
| start <- | ||
| formatTime defaultTimeLocale "%s" . addUTCTime 2 <$> getCurrentTime | ||
| [h0, h1, h2, h3] <- forM ["core0", "core1", "core2", "relay"] $ \x -> do | ||
| openFile ("/tmp/cardano-node-simple/" <> x) WriteMode |
There was a problem hiding this comment.
cf comment below, we have to redirect stderr & stdout somewhere and can't just use NoStream otherwise the node fails to ... fail and the processes never terminate on failure.
KtorZ
commented
May 15, 2019
| throwM e | ||
| HttpExceptionRequest _ e -> | ||
| return (status500, Left (HttpException e)) | ||
|
|
There was a problem hiding this comment.
Makes it possible to pattern match on HttpException failures, these occur when for instance, there's a connection failure because the target server isn't up there yet. It allows us to retry calls when polling.
KtorZ
force-pushed
the
KtorZ/integration-test-error-handling
branch
from
c9d15b2 to
8d95539
Compare
|
stylish haskell ¯_(ツ)_/¯ |
KtorZ
force-pushed
the
KtorZ/integration-test-error-handling
branch
from
8d95539 to
e96d7dd
Compare
|
🤷♂️ |
alecalve
pushed a commit
to alecalve/cardano-sl
that referenced
this pull request
May 16, 2019
alecalve
pushed a commit
to alecalve/cardano-sl
that referenced
this pull request
May 16, 2019
4038: Remove redundant [] in backupPhrase doc example r=KtorZ a=Anviking ## Description Mirroring cardano-foundation/cardano-wallet#263 ## Linked issue cardano-foundation/cardano-wallet#263 Co-authored-by: anviking <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#220
Overview
requestfunction such that it won't throwHttpExeptionRequestbut instead, put them down as value in theLeftbranch (to facilitate handling of such errors)asyncwouldn't terminate and just hang there. After a while, I discovered that this was because we close the stderr and stdout output streams for the cluster. With some open handles, the node can successfully shut itself down.Comments