Fix warning about license-file of lib/cli/cardano-wallet-cli.cabal #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
approved these changes
May 13, 2019
akegalj
approved these changes
May 13, 2019
paweljakubas
force-pushed
the
rvl/cabal-license-file
branch
from
9635da5 to
5d46ecc
Compare
paweljakubas
approved these changes
May 13, 2019
Warning: 'license-file: ../../LICENSE' is a relative path outside of the source tree. This will not work when generating a tarball with 'sdist'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was giving this warning:
We could also simplify by just removing all
license-filelines and the symlinks. This would be fine because the cabal files already saylicense: MIT, and there is a top-levelLICENSEfile.