Additional tweaks with regards to static address construction via the API #2318

KtorZ · 2020-11-12T16:11:17Z

Issue Number

ADP-461

Overview

9b362af
📍 return non-extended public key (without chain code) as 'ApiVerificationKey'
The chain code is useless because there's no further derivation that can happen at this stage. Plus, it does make it harder to re-use the output from the 'getWalletKey' endpoint into others because one needs to decode the bech32 string and strip away the chain code.
3b00583
📍 revise API documentation regarding address construction from script
- give more details about how scripts are constructed
- move description around so they show up correctly in ReDoc.
- move address endpoints into the 'Address' group and remove the 'Utils' group

Comments

TODO: use public key in script construction instead of hashes, and do the hashing internally.

lib/core/src/Cardano/Wallet/Api/Types.hs

specifications/api/swagger.yaml

paweljakubas

LGTM! Left some suggestions. Very fond of infographic you included!

…onKey' The chain code is useless because there's no further derivation that can happen at this stage. Plus, it does make it harder to re-use the output from the 'getWalletKey' endpoint into others because one needs to decode the bech32 string and strip away the chain code.

- give more details about how scripts are constructed - move description around so they show up correctly in ReDoc. - move address endpoints into the 'Address' group and remove the 'Utils' group

KtorZ · 2020-11-13T09:02:43Z

bors r+

2318: Additional tweaks with regards to static address construction via the API r=KtorZ a=KtorZ # Issue Number  ADP-461 # Overview  - 9b362af 📍 **return non-extended public key (without chain code) as 'ApiVerificationKey'** The chain code is useless because there's no further derivation that can happen at this stage. Plus, it does make it harder to re-use the output from the 'getWalletKey' endpoint into others because one needs to decode the bech32 string and strip away the chain code. - 3b00583 📍 **revise API documentation regarding address construction from script** - give more details about how scripts are constructed - move description around so they show up correctly in ReDoc. - move address endpoints into the 'Address' group and remove the 'Utils' group # Comments  TODO: use public key in script construction instead of hashes, and do the hashing internally.  Co-authored-by: KtorZ <[email protected]>

piotr-iohk · 2020-11-13T09:08:03Z

lib/core-integration/src/Test/Integration/Scenario/API/Shelley/Wallets.hs

@@ -998,23 +999,19 @@ spec = describe "SHELLEY_WALLETS" $ do
            matrix =


Idea for integration test:

create empty shelley wallet that has {walletId}

let paymentKey = GET /wallets/{walletId}/keys/utxo_external/0

let stakeKey = GET /wallets/{walletId}/keys/mutable_account/0

Construct address:

POST /addresses {payment: ${paymentKey}, stake: ${stakeKey}}

verify that this address is first address on {walletId}

Sounds like it would work 👍

iohk-bors · 2020-11-13T09:57:30Z

Build failed:

buildkite/cardano-wallet


Failures:
--
  |  
  | src/Test/Integration/Scenario/API/Shelley/Transactions.hs:642:10:
  | 1) API Specifications, SHELLEY_TRANSACTIONS, TRANS_TTL_01 - Pending transaction expiry
  | predicate failed on: SlotNo 75
  | expected expiry: SlotNo 37597
  | actual expiry: SlotNo 37672
  |  
  | To rerun use: --match "/API Specifications/SHELLEY_TRANSACTIONS/TRANS_TTL_01 - Pending transaction expiry/"
  |  
  | src/Test/Integration/Scenario/API/Shelley/Transactions.hs:676:10:
  | 2) API Specifications, SHELLEY_TRANSACTIONS, TRANS_TTL_02 - Custom transaction expiry
  | predicate failed on: SlotNo 76
  | expected expiry: SlotNo 1874
  | actual expiry: SlotNo 1950
  |  
  | To rerun use: --match "/API Specifications/SHELLEY_TRANSACTIONS/TRANS_TTL_02 - Custom transaction expiry/"
  |  
  | Randomized with seed 1701310684

#2295

Anviking · 2020-11-13T10:43:58Z

bors r+

2318: Additional tweaks with regards to static address construction via the API r=Anviking a=KtorZ # Issue Number  ADP-461 # Overview  - 9b362af 📍 **return non-extended public key (without chain code) as 'ApiVerificationKey'** The chain code is useless because there's no further derivation that can happen at this stage. Plus, it does make it harder to re-use the output from the 'getWalletKey' endpoint into others because one needs to decode the bech32 string and strip away the chain code. - 3b00583 📍 **revise API documentation regarding address construction from script** - give more details about how scripts are constructed - move description around so they show up correctly in ReDoc. - move address endpoints into the 'Address' group and remove the 'Utils' group # Comments  TODO: use public key in script construction instead of hashes, and do the hashing internally.  Co-authored-by: KtorZ <[email protected]>

iohk-bors · 2020-11-13T17:11:09Z

Build failed:

ci/hydra-build:required

  src/Test/Integration/Scenario/API/Shelley/StakePools.hs:433:5:
  1) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_QUIT_02 - Passphrase must be correct to quit
       uncaught exception: RequestException
       DecodeFailure "{\"code\":\"network_unreachable\",\"message\":\"The node backend is unreachable at the moment. Trying again in a bit might work.\"}"

#2320

KtorZ · 2020-11-16T08:05:01Z

bors retry

2318: Additional tweaks with regards to static address construction via the API r=Anviking a=KtorZ # Issue Number  ADP-461 # Overview  - 9b362af 📍 **return non-extended public key (without chain code) as 'ApiVerificationKey'** The chain code is useless because there's no further derivation that can happen at this stage. Plus, it does make it harder to re-use the output from the 'getWalletKey' endpoint into others because one needs to decode the bech32 string and strip away the chain code. - 3b00583 📍 **revise API documentation regarding address construction from script** - give more details about how scripts are constructed - move description around so they show up correctly in ReDoc. - move address endpoints into the 'Address' group and remove the 'Utils' group # Comments  TODO: use public key in script construction instead of hashes, and do the hashing internally.  Co-authored-by: KtorZ <[email protected]>

iohk-bors · 2020-11-16T08:39:46Z

Build failed:

buildkite/cardano-wallet

      src/Test/Integration/Scenario/API/Shelley/Transactions.hs:642:10:
      1) API Specifications, SHELLEY_TRANSACTIONS, TRANS_TTL_01 - Pending transaction expiry
           predicate failed on: SlotNo 64
           expected expiry: SlotNo 37456
           actual expiry: SlotNo 37520

      src/Test/Integration/Scenario/API/Shelley/Transactions.hs:676:10:
      2) API Specifications, SHELLEY_TRANSACTIONS, TRANS_TTL_02 - Custom transaction expiry
           predicate failed on: SlotNo 64
           expected expiry: SlotNo 1666
           actual expiry: SlotNo 1730

#2295

KtorZ · 2020-11-16T09:03:45Z

bors retry

2318: Additional tweaks with regards to static address construction via the API r=Anviking a=KtorZ # Issue Number  ADP-461 # Overview  - 9b362af 📍 **return non-extended public key (without chain code) as 'ApiVerificationKey'** The chain code is useless because there's no further derivation that can happen at this stage. Plus, it does make it harder to re-use the output from the 'getWalletKey' endpoint into others because one needs to decode the bech32 string and strip away the chain code. - 3b00583 📍 **revise API documentation regarding address construction from script** - give more details about how scripts are constructed - move description around so they show up correctly in ReDoc. - move address endpoints into the 'Address' group and remove the 'Utils' group # Comments  TODO: use public key in script construction instead of hashes, and do the hashing internally.  Co-authored-by: KtorZ <[email protected]>

iohk-bors · 2020-11-16T11:02:42Z

Build failed:

ci/hydra-build:required

  1) API Specifications, BYRON_MIGRATIONS, BYRON_MIGRATE_01 -  migrate a big wallet requiring more than one tx
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiUtxoStatistics {total = Quantity {getQuantity = 939993308496}, scale = ApiT {getApiT = Log10}, distribution = fromList [(10,0),(100,0),(1000,0),(10000,0),(100000,0),(1000000,0),(10000000,0),(100000000,0),(1000000000,0),(10000000000,94),(100000000000,0),(1000000000000,0),(10000000000000,0),(100000000000000,0),(1000000000000000,0),(10000000000000000,0),(45000000000000000,0)]}))
       expected: Just 100
        but got: Just 94

#2207

KtorZ · 2020-11-16T15:54:57Z

bors retry

2318: Additional tweaks with regards to static address construction via the API r=Anviking a=KtorZ # Issue Number  ADP-461 # Overview  - 9b362af 📍 **return non-extended public key (without chain code) as 'ApiVerificationKey'** The chain code is useless because there's no further derivation that can happen at this stage. Plus, it does make it harder to re-use the output from the 'getWalletKey' endpoint into others because one needs to decode the bech32 string and strip away the chain code. - 3b00583 📍 **revise API documentation regarding address construction from script** - give more details about how scripts are constructed - move description around so they show up correctly in ReDoc. - move address endpoints into the 'Address' group and remove the 'Utils' group # Comments  TODO: use public key in script construction instead of hashes, and do the hashing internally.  Co-authored-by: KtorZ <[email protected]>

iohk-bors · 2020-11-16T16:29:06Z

Build failed:

buildkite/cardano-wallet


1) API Specifications, SHELLEY_TRANSACTIONS, TRANS_TTL_01 - Pending transaction expiry
           predicate failed on: SlotNo 71
           expected expiry: SlotNo 37466
           actual expiry: SlotNo 37537

#2295

KtorZ · 2020-11-16T17:29:42Z

bors retry

please.

iohk-bors · 2020-11-16T18:11:08Z

Build succeeded:

KtorZ added the IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG label Nov 12, 2020

KtorZ requested review from paweljakubas and piotr-iohk November 12, 2020 16:11

KtorZ self-assigned this Nov 12, 2020

KtorZ force-pushed the KtorZ/ADP-461/additional-tweaks-address-construction branch from 3b00583 to 4c4c963 Compare November 12, 2020 16:13

paweljakubas reviewed Nov 13, 2020

View reviewed changes

lib/core/src/Cardano/Wallet/Api/Types.hs Outdated Show resolved Hide resolved

paweljakubas reviewed Nov 13, 2020

View reviewed changes

specifications/api/swagger.yaml Outdated Show resolved Hide resolved

paweljakubas reviewed Nov 13, 2020

View reviewed changes

specifications/api/swagger.yaml Outdated Show resolved Hide resolved

paweljakubas reviewed Nov 13, 2020

View reviewed changes

specifications/api/swagger.yaml Outdated Show resolved Hide resolved

paweljakubas approved these changes Nov 13, 2020

View reviewed changes

KtorZ added 2 commits November 13, 2020 10:02

revise API documentation regarding address construction from script

5c8cabe

- give more details about how scripts are constructed - move description around so they show up correctly in ReDoc. - move address endpoints into the 'Address' group and remove the 'Utils' group

KtorZ force-pushed the KtorZ/ADP-461/additional-tweaks-address-construction branch from 7462fb4 to 5c8cabe Compare November 13, 2020 09:02

piotr-iohk reviewed Nov 13, 2020

View reviewed changes

iohk-bors bot merged commit 602244c into master Nov 16, 2020

iohk-bors bot deleted the KtorZ/ADP-461/additional-tweaks-address-construction branch November 16, 2020 18:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Additional tweaks with regards to static address construction via the API #2318

Additional tweaks with regards to static address construction via the API #2318

KtorZ commented Nov 12, 2020

paweljakubas left a comment

KtorZ commented Nov 13, 2020

piotr-iohk Nov 13, 2020

KtorZ Nov 13, 2020

iohk-bors bot commented Nov 13, 2020 •

edited by Anviking

Loading

Anviking commented Nov 13, 2020

iohk-bors bot commented Nov 13, 2020 •

edited by KtorZ

Loading

KtorZ commented Nov 16, 2020

iohk-bors bot commented Nov 16, 2020 •

edited by KtorZ

Loading

KtorZ commented Nov 16, 2020

iohk-bors bot commented Nov 16, 2020 •

edited by KtorZ

Loading

KtorZ commented Nov 16, 2020

iohk-bors bot commented Nov 16, 2020 •

edited by KtorZ

Loading

KtorZ commented Nov 16, 2020

iohk-bors bot commented Nov 16, 2020

		@@ -998,23 +999,19 @@ spec = describe "SHELLEY_WALLETS" $ do
		matrix =

Additional tweaks with regards to static address construction via the API #2318

Additional tweaks with regards to static address construction via the API #2318

Conversation

KtorZ commented Nov 12, 2020

Issue Number

Overview

Comments

paweljakubas left a comment

Choose a reason for hiding this comment

KtorZ commented Nov 13, 2020

piotr-iohk Nov 13, 2020

Choose a reason for hiding this comment

KtorZ Nov 13, 2020

Choose a reason for hiding this comment

iohk-bors bot commented Nov 13, 2020 • edited by Anviking Loading

Anviking commented Nov 13, 2020

iohk-bors bot commented Nov 13, 2020 • edited by KtorZ Loading

KtorZ commented Nov 16, 2020

iohk-bors bot commented Nov 16, 2020 • edited by KtorZ Loading

KtorZ commented Nov 16, 2020

iohk-bors bot commented Nov 16, 2020 • edited by KtorZ Loading

KtorZ commented Nov 16, 2020

iohk-bors bot commented Nov 16, 2020 • edited by KtorZ Loading

KtorZ commented Nov 16, 2020

iohk-bors bot commented Nov 16, 2020

iohk-bors bot commented Nov 13, 2020 •

edited by Anviking

Loading

iohk-bors bot commented Nov 13, 2020 •

edited by KtorZ

Loading

iohk-bors bot commented Nov 16, 2020 •

edited by KtorZ

Loading

iohk-bors bot commented Nov 16, 2020 •

edited by KtorZ

Loading

iohk-bors bot commented Nov 16, 2020 •

edited by KtorZ

Loading