Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cardano-addresses to 3.1.0 #2317

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Update cardano-addresses to 3.1.0 #2317

merged 1 commit into from
Nov 17, 2020

Conversation

hasufell
Copy link
Contributor

No description provided.

@hasufell hasufell requested review from rvl and KtorZ November 12, 2020 15:44
@hasufell hasufell force-pushed the jospald/update-cardano-addresses branch 2 times, most recently from 5327c8a to e51a917 Compare November 12, 2020 18:46
@hasufell
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 13, 2020
@iohk-bors
Merge #2317
2c382c5 
2317: Update cardano-addresses to 3.0.0 r=hasufell a=hasufell



Co-authored-by: Julian Ospald <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 13, 2020 •
edited by rvl
Loading

Build failed:

#2292 - unit test timeout on linux.

@hasufell hasufell force-pushed the jospald/update-cardano-addresses branch from e51a917 to 2fd006b Compare November 13, 2020 17:01
@hasufell hasufell changed the title Update cardano-addresses to 3.0.0 Update cardano-addresses to 3.1.0 Nov 13, 2020
@hasufell hasufell requested a review from KtorZ November 13, 2020 17:02
@hasufell
Copy link
Contributor Author

Updated to 3.1.0

rvl
rvl approved these changes Nov 15, 2020
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/shelley/src/Cardano/Wallet/Shelley/Compatibility.hs
@@ -232,6 +230,7 @@ import Shelley.Spec.Ledger.BaseTypes
import Type.Reflection
( Typeable, typeRep )

import qualified Cardano.Address.Style.Shelley as SH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have preferred not changing it to use qualified imports. This module is called ...Shelley.Compatibility so a prefix like SH (I assume it stands for Shelley?) is redundant.

@rvl
Copy link
Contributor

rvl commented Nov 15, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 15, 2020
@iohk-bors
Merge #2317
a746a71 
2317: Update cardano-addresses to 3.1.0 r=rvl a=hasufell



Co-authored-by: Julian Ospald <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 15, 2020 •
edited by Anviking
Loading

Build failed:

Proper failure - Cardano.Wallet.Api.Types - there are some golden JSON tests failing.
#expected

@hasufell hasufell force-pushed the jospald/update-cardano-addresses branch from 2fd006b to 3513e4e Compare November 16, 2020 11:02
@hasufell
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 16, 2020
@iohk-bors
Merge #2317
51bd755 
2317: Update cardano-addresses to 3.1.0 r=hasufell a=hasufell



Co-authored-by: Julian Ospald <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 16, 2020 •
edited by Anviking
Loading

Build failed:


  src/Test/Integration/Framework/DSL.hs:716:11:
  1) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_LIST_01 - List stake pools, has non-zero saturation & stake
       Quantity {getQuantity = Percentage {getPercentage = 0 % 1}} does not satisfy (> Quantity {getQuantity = Percentage {getPercentage = 0 % 1}})
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right [ApiStakePool {id = ApiT {getApiT = PoolId {getPoolId = "\180Wh\193\162\218K\209>\188\170\RS\165\DC4\b\237\163\GS\204!v\\\203\212\a\205\169\242"}}, metrics = ApiStakePoolMetrics {nonMyopicMemberRewards = Quantity {getQuantity = 16700493703441174}, relativeStake = Quantity {getQuantity = Percentage {getPercentage = 1 % 2500}}, saturation = 1.3298419487170969e-3, producedBlocks = Quantity {getQuantity = 200}}, metadata = Just (ApiT {getApiT = StakePoolMetadata {ticker = StakePoolTicker {unStakePoolTicker = "GPC"}, name = "Genesis Pool C", description = Just "Lorem Ipsum Dolor Sit Amet.", homepage = "https://iohk.io"}}), cost = Quantity {getQuantity = 0}, margin = Quantity {getQuantity = Percentage {getPercentage = 1 % 10}}, pledge = Quantity {getQuantity = 1000000000000}, retirement = Just (ApiEpochInfo {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 100000}}, epochStartTime = 2021-01-01 22:06:36 UTC}), flags = []},ApiStakePool {id = ApiT {getApiT = PoolId {getPoolId = "\ESC=\193\156j\184\158\175\252\133\SOH\243u\187\ETX\193\ESC\248\237]\CAN76\177\216\EOT\DC3\214"}}, metrics = ApiStakePoolMetrics {nonMyopicMemberRewards = Quantity {getQuantity = 15781966549751909}, relativeStake = Quantity {getQuantity = Percentage {getPercentage = 3 % 10000}}, saturation = 9.753989441037433e-4, producedBlocks = Quantity {getQuantity = 168}}, metadata = Just (ApiT {getApiT = StakePoolMetadata {ticker = StakePoolTicker {unStakePoolTicker = "GPB"}, name = "Genesis Pool B", description = Nothing, homepage = "https://iohk.io"}}), cost = Quantity {getQuantity = 0}, margin = Quantity {getQuantity = Percentage {getPercentage = 1 % 10}}, pledge = Quantity {getQuantity = 1000000000000}, retirement = Just (ApiEpochInfo {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 1000000}}, epochStartTime = 2022-02-22 14:06:36 UTC}), flags = []},ApiStakePool {id = ApiT {getApiT = PoolId {getPoolId = "\187\DC1L\179}u\250\ENQ&\ETX(\194\&5\163\218\226\149\163=\v\166t\165\235\RS>V\142"}}, metrics = ApiStakePoolMetrics {nonMyopicMemberRewards = Quantity {getQuantity = 12942933364523745}, relativeStake = Quantity {getQuantity = Percentage {getPercentage = 0 % 1}}, saturation = 7.841306650921694e-5, producedBlocks = Quantity {getQuantity = 0}}, metadata = Just (ApiT {getApiT = StakePoolMetadata {ticker = StakePoolTicker {unStakePoolTicker = "GPD"}, name = "Genesis Pool D", description = Just "Lorem Ipsum Dolor Sit Amet.", homepage = "https://iohk.io"}}), cost = Quantity {getQuantity = 0}, margin = Quantity {getQuantity = Percentage {getPercentage = 1 % 10}}, pledge = Quantity {getQuantity = 2000000000000}, retirement = Nothing, flags = []}])
       Waited longer than 90s to resolve action: "list pools returns non-empty list".

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_LIST_01 - List stake pools/has non-zero saturation & stake/"

Randomized with seed 1757070656

#2224

@rvl
Copy link
Contributor

rvl commented Nov 17, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 17, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit 98c35df into master Nov 17, 2020
@iohk-bors iohk-bors bot deleted the jospald/update-cardano-addresses branch November 17, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

@KtorZ KtorZ Awaiting requested review from KtorZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hasufell @rvl @KtorZ