Testing maintenance actions #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
added
the
ADDING FEATURE
hasufell
suggested changes
Nov 12, 2020
| updateMetadataSource ctx "direct" | ||
| verifyMetadataSource ctx FetchDirect | ||
| triggerMaintenanceAction ctx "gc_stake_pools" | ||
| eventually "GC Status shows as NotApplicable" $ do |
There was a problem hiding this comment.
We should have an eventually that isn't 90+ seconds. Triggering this should be in the realm of <10s usually.
There was a problem hiding this comment.
ok, added eventually with 10s timeout.
…urce is none or direct
piotr-iohk
force-pushed
the
piotr/testing_maintenance_actions
branch
from
afda594 to
e5cce92
Compare
hasufell
approved these changes
Nov 12, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 12, 2020
2314: Testing maintenance actions r=piotr-iohk a=piotr-iohk # Issue Number ADP-478 # Overview - 2bb8359 Move updateMetadataSource and verifyMetadataSource to DSL.hs - 26812b5 Make PostPoolMaintenance to be 204 No Content to comply with swagger - afda594 Integration tests for triggering maintenance action while metadata source is none or direct # Comments First two test from the "proposal" https://jira.iohk.io/browse/ADP-478?focusedCommentId=27784&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-27784 And small fix for [postMaintenanceAction](https://input-output-hk.github.io/cardano-wallet/api/edge/#operation/postMaintenanceAction) to return `204` and no content. Co-authored-by: Piotr Stachyra <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-478
Overview
2bb8359
Move updateMetadataSource and verifyMetadataSource to DSL.hs
26812b5
Make PostPoolMaintenance to be 204 No Content to comply with swagger
afda594
Integration tests for triggering maintenance action while metadata source is none or direct
Comments
First two test from the "proposal" https://jira.iohk.io/browse/ADP-478?focusedCommentId=27784&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-27784
And small fix for postMaintenanceAction to return
204and no content.