Move Hash type and related functions into separate module.
#2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
added
IMPROVEMENT
rvl
added
the
IMPROVEMENT
rvl
approved these changes
Nov 9, 2020
There was a problem hiding this comment.
Seems reasonable to re-use the Hash type for monetary policy ID.
This will fix the circular dependency.
Moving more types to separate modules and not re-exporting from a single types module may help reduce compilation in future.
Looks fine, as long as it builds and passes stylish-haskell.
jonathanknowles
force-pushed
the
jonathanknowles/extract-out-hash-type
branch
from
c2aac52 to
a0e92b9
Compare
This allows code to use the `Hash` type without having to incur a dependency on the `Primitive.Types` module, which is already very large and slow to recompile.
jonathanknowles
force-pushed
the
jonathanknowles/extract-out-hash-type
branch
from
a0e92b9 to
378930d
Compare
jonathanknowles
changed the title
Hash type and related functions into dedicated module.Hash type and related functions into separate module.
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 9, 2020
2303: Move `Hash` type and related functions into separate module. r=jonathanknowles a=jonathanknowles # Issue Number Preparation for [ADP-347](https://jira.iohk.io/browse/ADP-347). # Overview This PR moves the `Hash` type and related functions to a separate module `Cardano.Wallet.Primitive.Types.Hash`. This allows code to use the `Hash` type without having to incur a dependency on the `Primitive.Types` module, which is already very large and slow to recompile. # Comments This PR doesn't re-export the `Hash` type from `Primitive.Types`. Although it would be convenient to be able to import everything from `Primitive.Types` in one go (with a qualified import), it would also create a compilation bottleneck, since anything that imported `Hash` from the `Primitive.Types` module would have to depend on everything required to build `Primitive.Types`. This PR follows the advice presented in [Keeping Compilation Fast](https://www.parsonsmatt.org/2019/11/27/keeping_compilation_fast.html) by Matt Parsons. Co-authored-by: Jonathan Knowles <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Preparation for ADP-347.
Overview
This PR moves the
Hashtype and related functions to a separate moduleCardano.Wallet.Primitive.Types.Hash. This allows code to use theHashtype without having to incur a dependency on thePrimitive.Typesmodule, which is already very large and slow to recompile.Comments
This PR doesn't re-export the
Hashtype fromPrimitive.Types.Although it would be convenient to be able to import everything from
Primitive.Typesin one go (with a qualified import), it would also create a compilation bottleneck, since anything that importedHashfrom thePrimitive.Typesmodule would have to depend on everything required to buildPrimitive.Types.This PR follows the advice presented in Keeping Compilation Fast by Matt Parsons.