Fix wrong setup/expectation in TRANS_CREATE_03

[Anviking]

Issue Number

#2298

Overview

• Make wDest start empty, instead of with amt balance, such that the expectation makes sense.
• Haven't run this yet though. Fixed.

Comments

It used to create a wDest wallet with amt balance, sent another amt to
it, and expect the balance to be amt. Somewhat astounding that this
didn't fail more often.

src/Test/Integration/Scenario/API/Shelley/Transactions.hs:435:26:
      1) API Specifications, SHELLEY_TRANSACTIONS, TRANS_CREATE_03 - 0 balance after transaction
           While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiWallet {id = ApiT {getApiT = WalletId {getWalletId = 278f9ebf2dcf1cb23e1af27281daed107333fd16}}, addressPoolGap = ApiT {getApiT = AddressPoolGap {getAddressPoolGap = 20}}, balance = ApiT {getApiT = WalletBalance {available = Quantity {getQuantity = 2000000}, total = Quantity {getQuantity = 2000000}, reward = Quantity {getQuantity = 0}}}, delegation = ApiWalletDelegation {active = ApiWalletDelegationNext {status = NotDelegating, target = Nothing, changesAt = Nothing}, next = []}, name = ApiT {getApiT = WalletName {getWalletName = "Empty Wallet"}}, passphrase = Just (ApiWalletPassphraseInfo {lastUpdatedAt = 2020-11-04 18:51:44.994771905 UTC}), state = ApiT {getApiT = Ready}, tip = ApiBlockReference {absoluteSlotNumber = ApiT {getApiT = SlotNo 2113}, slotId = ApiSlotId {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 11}}, slotNumber = ApiT {getApiT = SlotInEpoch {unSlotInEpoch = 33}}}, time = 2020-11-04 18:53:51.6 UTC, block = ApiBlockInfo {height = Quantity {getQuantity = 946}}}}))
           Waited longer than 90s to resolve action: "Wallet balance is as expected".
           expected: Quantity {getQuantity = 1000000}
            but got: Quantity {getQuantity = 2000000}
      To rerun use: --match "/API Specifications/SHELLEY_TRANSACTIONS/TRANS_CREATE_03 - 0 balance after transaction/"

Two possible fixes:
1. Make the wDest start with 0 balance
2. Expect wDest to have 2*amt

1 makes more sense in a way, but we actually rely on wDest having amt
balance to predict the fees, /before/ creating wSrc. So 2 is easer in
this case.

[Anviking]

Seems the first method didn't work since wDest starting with amt was needed to estimate fees. Changed to expect 2*amt instead.

[piotr-iohk]

Thx!

[Anviking]

bors r+

[iohk-bors]

Build succeeded:

• buildkite/cardano-wallet
• ci/hydra-build:required