Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More details on index param for Sign metadata and Get public key endpoints in swagger. #2274

Merged
merged 1 commit into from
Oct 27, 2020
Merged

More details on index param for Sign metadata and Get public key endpoints in swagger. #2274

merged 1 commit into from
Oct 27, 2020

Conversation

piotr-iohk
Copy link
Contributor

Issue Number

ADP-509 / ADP-474

Overview

  • 9c6dd06
    More details on index param for Sign metadata and Get public key endpoints in swagger.

Comments

Screenshot from 2020-10-27 10-36-55

@piotr-iohk piotr-iohk added the IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG label Oct 27, 2020
@piotr-iohk piotr-iohk requested a review from KtorZ October 27, 2020 09:39
@piotr-iohk piotr-iohk self-assigned this Oct 27, 2020
@KtorZ
Copy link
Member

KtorZ commented Oct 27, 2020

bors merge

iohk-bors bot added a commit that referenced this pull request Oct 27, 2020
@iohk-bors
Merge #2274
56356f1 
2274: More details on index param for `Sign metadata` and `Get public key` endpoints in swagger. r=KtorZ a=piotr-iohk

# Issue Number

ADP-509 / ADP-474

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- 9c6dd06
  More details on index param for `Sign metadata` and `Get public key` endpoints in swagger.

# Comments

![Screenshot from 2020-10-27 10-36-55](https://user-images.githubusercontent.com/42900201/97283754-88fa2300-1840-11eb-9586-8be33267dd69.png)



Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 27, 2020 •
edited by KtorZ
Loading

Build failed:


src/Test/Integration/Scenario/API/Byron/Addresses.hs:430:13:
--
  | 1) API Specifications, BYRON_ADDRESSES, ADDRESS_IMPORT_05 - I can import 15000 of addresses
  | While verifying (Status {statusCode = 200, statusMessage = "OK"},Right [])
  | Waited longer than 90s (more than 2 epochs) to resolve action: "Addresses are imported".
  | expected: 15000
  | but got: 0

ADP-619 #2218

@piotr-iohk
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 27, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit 5573ad8 into master Oct 27, 2020
@iohk-bors iohk-bors bot deleted the piotr/update_swagger_about_soft_derivation branch October 27, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

Assignees

@piotr-iohk piotr-iohk

Labels
IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotr-iohk @KtorZ